Conversation
Signed-off-by: BrianTeeman <brian@teeman.net>
|
The issue is labelled as "Feature", so this PR would also get that label. But we have already feature freeze in 5.4 and 6.0. So it would have to go into 6.1. |
|
Or is it a bug fix because different to the original intention of the issue? |
|
For me its a bug as its broken behaviour (and basically going back to the original j3 behaviour) |
|
I've changed the label from feature to bug. No need to hurry, if it does not go into beta 2 it will go into beta 3. |
|
P.S:: But can we close the issue? |
|
My bad I referenced the wrong issue - i have now corrected it to #29942 |
|
@brianteeman Can you close the issue now as we have a pull request? |
|
@brianteeman I seem to have found a bug? Without the PR applied, as you described the Start/Finish Featured is typed in but does not get saved: 
but 
The Inspect Element view when PR is applied (the field flashes --> gets hidden) 
Hope that helps. Fresh install Joomla 5.4 Nightly - 28 August 2025 00:42:47 UTC, Install Blog data, installed French, Installed Multi-lingual Same Data, caching On conservative, Error Reporting: Maximum, HTTPS - Entire site, SEF turned on. |
|
Please read the test instructions |
To be more precise: Section "Additional comments" in the testing instructions. |
|
its there twice - also in the summary of changes |
|
( I had read that and it does work WITH setting the article to Featured but causing the fields to be hidden seemed so opposite of what we usually do (we typically do not change the behavior or an already established feature (aside from major releases) that it felt like we're basically introducing a b/c break in the way the CMS behaves for a user and I thought it was important to say something. ) (sorry if I was wrong, just trying to help). If you think it isn't or it's fine for now, I will validate my test. |
|
@exlemor its not a b/c break. The fields are only relevant if you have already set the article to featured. The bug/confusion is that people expect to be able to just set the start and end dates withotu first setting it to featured. If you try that then the dates are not stored and you think its broken. It is common throughout Joomla to have certain fields hidden and only shown when the feature is enabled not sure what you mean when you say "opposite of what we usually do" Note it completely doesnt work at all when using workflows - thats a seperate issue |
|
I have tested this item ✅ successfully on 259abcd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46003. |
|
I have tested this item ✅ successfully on 7ade64d
With the PR, graft full package, w/o workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46003. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46003. |
|
Thank you @brianteeman for your contribution. Thank you @exlemor for testing. |
Pull request for
45838#29942Steps to reproduce the issue
not using workflows
Create an article and in the publishing tab set a date for feature start and save
Expected result
Article is saved and on the set date the article will be featured - basically same behaviour as with start publishing
Actual result
Article is saved without any error but the date is NOT saved.
Additional comments
You have to set the article to be featured before the date will be saved. This bug was caused by a change when workflows was integrated . Before that change the start/end featured fields were only displayed when the article was set to featured.
Summary of Changes
This simple PR restores the behaviour that the start/end featured fields are only displayed after already setting the article to be featured.
If you are using workflows then there is no change. The start/end featured are always displayed and the date is never saved even if the article has been set to featured with workflows. #35308
So not a perfect fix but at least it fixes it for the majority of users who dont use workflows - unless someone has a better fix for all cases
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed