[6.1] - a11y - Contain page content by landmark#45988
[6.1] - a11y - Contain page content by landmark#45988HLeithner merged 11 commits intojoomla:6.1-devfrom
Conversation
|
I agree with adding the landmark. Not sure about the arialabel. Will check in more detail later but I don't think it's needed or particularly helpful |
|
I would like to have a landmark here and get rid of this ugly "missing landmark" error. |
|
Aside means it is complimentary to the main region but I wonder if it can be considered as complimentary as it has the page h1 in it. |
|
The This suggests it's not the correct landmark region to use here |
|
A <div role="complementary" could match. |
that is the exact same thing as |
I was surprised that the label would identify the text as the referred id is to the div and not the individual text. So that arial label is both the h1 and the h2 In general a region only needs a label if there are more than one on the page but i dont suppose it harms having one anyway. I wonder if this is the real |
|
My 2 cents here. But, besides getting rid of the error in automatic detection tools. Does this help to anyone? Everytime I investigate about landmarks I end giving up because of the scarce support hey have in browsers and screen readers. |
|
I have tested this item ✅ successfully on a692226 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
I have tested this item ✅ successfully on a692226 For me it looks valid This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
element "aside" is missing in above comment This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
I just dont see how a region with the h1 inside it can ever be considered to be complimentary |
fair point. |
|
Thank you for the work on this, pushed to 6.1 as not fixing a bug. |
… admin login page
|
The following text was forwarded to me This PR #45988 does not solve the problem. Accessibility and Usability AnalysisJoomla Administrator Login Page 1. Scope of the analysisThis analysis concerns the accessibility and usability of the Joomla Administrator login page, with particular focus on:
2. Key accessibility and usability issues2.1. Heading structure and content identificationPrimary issue: The only heading that correctly describes the purpose of the page (“Joomla Administrator Login”) is marked as an H2 and is located:
The H1 heading (“Polskie Centrum Joomla”):
Impact: Screen reader users do not receive a clear and immediate answer to the question: Navigating by headings does not lead users to the login task, and the semantic hierarchy of the page does not reflect its functional purpose. This affects compliance with:
2.2. Landmark structure and user orientationCurrent state:
Impact: Landmark navigation is ineffective. 2.3. Task-oriented usabilityThe page serves one primary task: logging in. Although the form controls are correctly labelled and required attributes are present, the page lacks:
Impact: This increases cognitive load and reduces clarity, particularly for:
3. Core structural principleThe H1 heading must describe the main purpose of the page and be located within the Branding or organisational identification must not replace or override the functional heading of a task-oriented page such as a login screen. 4. Recommended page structure4.1. Semantic role allocation
4.2. Example of a corrected semantic structure |
|
After that I received a draft of the login page standard that was developed. Standard: Backend Login PageAccessibility and Usability Requirements Version1.0 ScopeThis standard defines the minimum accessibility and usability requirements for login pages to the administrative or backend area of a website, including CMS platforms (e.g. Joomla, WordPress, Drupal). The login page is treated as a task-oriented page with a single primary purpose: user authentication. 1. Core principleThe structure of the login page must clearly communicate its purpose and allow users to immediately identify:
This must be achieved through correct use of headings, landmarks, and semantic relationships, independent of visual layout. 2. Page purpose and heading structure2.1. Main heading (H1)
2.2. Secondary headings
3. Landmark structureThe page must use landmarks to expose its functional structure to assistive technologies. Required landmarks:
Optional landmarks:
Content must not be placed outside landmarks unless it is purely decorative. 4. Login form requirements4.1. Semantic association
4.2. Form controls
5. Branding and organisational information
6. Support and help content
7. Accessibility rationaleThis standard ensures:
8. Non-conformance examplesThe following patterns are non-conformant:
9. Implementation noteThis standard can be implemented without visual redesign. |
|
My question is... do you all agree with the provided information? And if so... I will adjust this PR to meet the requirements setup in the provided draft. |
Absolutely - I've said the same myself in the past as have others |
…a11y-best-practice-landmark
|
The PR has been adjusted, based on J6.1-dev With the suggestions as described in #45988 (comment)
|
|
I have tested this item ✅ successfully on 52bf793 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
I have tested this item ✅ successfully on 52bf793 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45988. |
|
thanks |
Pull Request for no issue
Summary of Changes
It is best practice that all content is contained by a landmark. On the login page of administrator the sidebar is not contained by a landmark. This PR will fix this
Testing Instructions
sidebar-wrapperis not contained by a landmark.sidebar-wrapperis contained in landmark<aside>Landmark
<aside>is chosen because sidebar is supplementary support infoActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed