[5.3] Does check the server error logs in system tests#45409
Merged
laoneo merged 3 commits intojoomla:5.3-devfrom Apr 30, 2025
Merged
[5.3] Does check the server error logs in system tests#45409laoneo merged 3 commits intojoomla:5.3-devfrom
laoneo merged 3 commits intojoomla:5.3-devfrom
Conversation
brianteeman
reviewed
Apr 29, 2025
Co-authored-by: Brian Teeman <brian@teeman.net>
Contributor
|
Works in my local test environment. Do some other test cases. |
Contributor
|
✅ Tested successfully on MacBook Air M3 Sequoia 15.4.1, with local PHP 8.4.6, Apache 2.4.62, MariaDB 11.6.2 and with Docker container based PHP 8.4.3, Apache 2.4.62, MySQL 8.3 1. Overall System Test Time
2. Functionality
|
muhme
added a commit
to muhme/joomla-branches-tester
that referenced
this pull request
Apr 30, 2025
e.g as test instructions from joomla/joomla-cms#45409 with inserting error_log('cheshire-cat-notice-test'); results in [Wed Apr 30 14:12:34.270360 2025] [php:notice] [pid 190:tid 190] [client 10.0.0.1:65242] cheshire-cat-notice-test, referer: http://host.docker.internal:7053/administrator/index.php?option=com_actionlogs&view=actionlogs
4 tasks
alikon
added a commit
to joomla-extensions/weblinks
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Checks the error log file after each test if there is an entry written to it.
Testing Instructions
Place somewhere in the CMS code the following code snippet ( I added it for testing to administrator/components/com_actionlogs/src/Model/ActionlogsModel.php into the delete function)
error_log('test');Run the system test ( was running tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js).
Actual result BEFORE applying this Pull Request
The test was running through.
Expected result AFTER applying this Pull Request
The test failed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed