Skip to content

[6.0] Remove leftover reCaptcha files#44321

Merged
Bodge-IT merged 8 commits intojoomla:6.0-devfrom
Fedik:captcha-remove-js
Feb 12, 2025
Merged

[6.0] Remove leftover reCaptcha files#44321
Bodge-IT merged 8 commits intojoomla:6.0-devfrom
Fedik:captcha-remove-js

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Oct 20, 2024 •
edited
Loading

Summary of Changes

Remove leftover reCaptcha files, forgoten in #41530

Testing Instructions

Code review.

Or build the release packge, and check for /media/plg_captcha_recaptcha/ and /media/plg_captcha_recaptcha_invisible/. These folder should not exists.

Actual result BEFORE applying this Pull Request

recaptcha files in release packge

Expected result AFTER applying this Pull Request

no recaptcha files in release packge

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: Recaptcha plugins Manual#182
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Oct 20, 2024
Quy
Quy reviewed Nov 3, 2024
View reviewed changes
@Hackwar Hackwar added Feature b/c break This item changes the behavior in an incompatible why. HEADS UP labels Nov 23, 2024
@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Nov 24, 2024

@Hackwar where is b/c break?

@Fedik
Merge branch '6.0-dev' into captcha-remove-js
e287eea 
 Conflicts:
	build/media_source/plg_captcha_recaptcha_invisible/js/recaptcha.es6.js
@Hackwar
Copy link
Copy Markdown
Member

Hackwar commented Nov 24, 2024

I just added the label as a technicality because we are removing files which people might still be using, but since it is against 6.0 anyway, it shouldn't really matter. I mean, in case someone wants a list of b/c breaks, now they can filter by that.

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Nov 24, 2024

Okay

I just added the label as a technicality because we are removing files which people might still be using

This does not removing files on update, only form release packge, which should be done in #41530 but I forgot.
The files will stay on User side if they in use.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 25, 2024

I have tested this item ✅ successfully on 2c91f60

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Feb 5, 2025

I have tested this item ✅ successfully on 5c18128

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Feb 5, 2025

rtc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2025
@Bodge-IT Bodge-IT merged commit 3f23711 into joomla:6.0-dev Feb 12, 2025
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 12, 2025
@QuyTon QuyTon added this to the Joomla! 6.0.0 milestone Feb 12, 2025
@Fedik Fedik deleted the captcha-remove-js branch February 12, 2025 19:34
@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 15, 2025

If the files shall not be deleted on update, it needs to add them to the list of exceptions in the build/deleted_file_check.php script.

I will make a follow-up PR for that today or tomorrow.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 15, 2025
@richard67
Add excluded folders from PR joomla#44321
e5d365d
@richard67 richard67 mentioned this pull request Feb 15, 2025
Merged
4 tasks
@richard67
Copy link
Copy Markdown
Member

richard67 commented Feb 15, 2025

See #44912 .

richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 28, 2025
@richard67
Add excluded folders from PR joomla#44321
d9d5279
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 1, 2025
@richard67
Add excluded folders from PR joomla#44321
821fffd
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 31, 2025
@richard67
Add excluded folders from PR joomla#44321
ba06f1f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 13, 2025
@richard67
Add excluded folders from PR joomla#44321
8a3bf86
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 13, 2025
@richard67
Add excluded folders from PR joomla#44321
3d2b73f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 13, 2025
@richard67
Add excluded folders from PR joomla#44321
14a22af
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 17, 2025
@richard67
Add excluded folders from PR joomla#44321
961f425
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 24, 2025
@richard67
Add excluded folders from PR joomla#44321
54119ab
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2025
@richard67
Add excluded folders from PR joomla#44321
4112810
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 30, 2025
@richard67
Add excluded folders from PR joomla#44321
037289c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 18, 2025
@richard67
Add excluded folders from PR joomla#44321
b3c9a3e
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 19, 2025
@richard67
Add excluded folders from PR joomla#44321
65caba9
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 9, 2025
@richard67
Add excluded folders from PR joomla#44321
c000500
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 11, 2025
@richard67
Add excluded folders from PR joomla#44321
9bb8c57
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 19, 2025
@richard67
Add excluded folders from PR joomla#44321
be40556
richard67 added a commit to richard67/joomla-cms that referenced this pull request Nov 19, 2025
@richard67
Add excluded folders from PR joomla#44321
0763142
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 14, 2025
@richard67
Add excluded folders from PR joomla#44321
4816d34
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 14, 2025
@richard67
Add excluded folders from PR joomla#44321
a6b425a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 19, 2025
@richard67
Add excluded folders from PR joomla#44321
c8b340a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 19, 2025
@richard67
Add excluded folders from PR joomla#44321
e5a5bb3
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 19, 2025
@richard67
Add excluded folders from PR joomla#44321
e52261e
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 20, 2025
@richard67
Add excluded folders from PR joomla#44321
af181dd
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 22, 2025
@richard67
Add excluded folders from PR joomla#44321
db2c8ec
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 22, 2025
@richard67
Add excluded folders from PR joomla#44321
893f988
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 22, 2025
@richard67
Add excluded folders from PR joomla#44321
97389ef
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 23, 2025
@richard67
Add excluded folders from PR joomla#44321
8ecfde8
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 23, 2025
@richard67
Add excluded folders from PR joomla#44321
29583b7
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 17, 2026
@richard67
Add excluded folders from PR joomla#44321
4f3a7c1
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 17, 2026
@richard67
Add excluded folders from PR joomla#44321
5afa68c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 24, 2026
@richard67
Add excluded folders from PR joomla#44321
05213ff
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 24, 2026
@richard67
Add excluded folders from PR joomla#44321
219f28d
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 4, 2026
@richard67
Add excluded folders from PR joomla#44321
10cf720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Milestone

Joomla! 6.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Fedik @Hackwar @Quy @laoneo @richard67 @Bodge-IT @joomla-cms-bot @QuyTon @HLeithner