[5.1] Use Dialog for Plugin editing#42447
Merged
LadySolveig merged 7 commits intojoomla:5.1-devfrom Jan 10, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 974f595 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 974f595 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447. |
Contributor
|
Thank you @Fedik and also for testing @Quy @viocassel |
This was referenced Jan 13, 2024
alikon
added a commit
to alikon/joomla-cms
that referenced
this pull request
Jan 14, 2024
alikon
added a commit
to alikon/joomla-cms
that referenced
this pull request
Jan 14, 2024
alikon
added a commit
to alikon/joomla-cms
that referenced
this pull request
Jan 14, 2024
alikon
added a commit
to alikon/joomla-cms
that referenced
this pull request
Jan 14, 2024
This was referenced Apr 17, 2024
4 tasks
Contributor
|
This is completely wrong - at least for the redirects. It stops checking if the plugin is enabled or disabled. it only checks if the plugin is installed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use Dialog for Plugin editing modals.
Similar to #42423
Testing Instructions
Run
npm install.Disable plugins:
Content - Smart Search
System - Redirect
Visit Finder Index overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.
Visit Redirects overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.
Actual result BEFORE applying this Pull Request
Works with BS modal
Expected result AFTER applying this Pull Request
Works with Joomla Dialog
Link to documentations
Please select:
References: