[4.4] Broken language comment#42425
Merged
MacJoom merged 2 commits intojoomla:4.4-devfrom Nov 29, 2023
Merged
Conversation
The recent security update has exposed a bug in a language string. You cannot have a " in a comment.
Contributor
|
Could you also fix:
|
Contributor
|
I have tested this item ✅ successfully on 8d2e481 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425. |
Contributor
Author
|
I did a quick grep and can't find any more |
Contributor
|
I have tested this item ✅ successfully on 8d2e481 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42425. |
Contributor
|
Thanks for fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent security update has exposed a bug in a language string. You cannot have a " in a comment.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Comment
This will need to be upmerged to j5 AND @tecpromotion will need to notify translators
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed