Skip to content

[5.x] Missing Strings [a11y]#42387

Merged
bembelimen merged 5 commits intojoomla:5.0-devfrom
brianteeman:list_limit
Dec 16, 2023
Merged

[5.x] Missing Strings [a11y]#42387
bembelimen merged 5 commits intojoomla:5.0-devfrom
brianteeman:list_limit

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Summary of Changes

Many of the labels for the filters in the xtd-editor modals were either missing or the language string was missing or the language string was incorrect when the xtd-editor modals are used in the frontend

I have made this as a change to 5.0 as I see this as a bug fix and not a feature

Testing Instructions

Enable debug lang
Log in to site and create or edit an article
Open each of the xtd-editor modals as below
image

Actual result BEFORE applying this Pull Request

Many untranslated strings listed in the debug

Expected result AFTER applying this Pull Request

No untranslated strings listed in the debug

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.0-dev labels Nov 22, 2023
@HLeithner
Copy link
Copy Markdown
Member

Can I expect that the description attributes has never (at at least currently) been used?

@HLeithner HLeithner added the bug label Nov 23, 2023
@brianteeman
Copy link
Copy Markdown
Contributor Author

Can I expect that the description attributes has never (at at least currently) been used?

that is correct and they are not used in the equivalent admin views.

@ghost
Copy link
Copy Markdown

ghost commented Nov 23, 2023

I have tested this item ✅ successfully on 0ddd40f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42387.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 0ddd40f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42387.

@Quy Quy removed the bug label Nov 23, 2023
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 23, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42387.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 23, 2023
@Quy Quy added the bug label Nov 23, 2023
@bembelimen bembelimen merged commit f267acd into joomla:5.0-dev Dec 16, 2023
@bembelimen
Copy link
Copy Markdown
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 16, 2023
@bembelimen bembelimen added this to the Joomla! 5.0.2 milestone Dec 16, 2023
@brianteeman brianteeman deleted the list_limit branch December 16, 2023 09:05
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jan 11, 2024
Kostelano added a commit to Joomla-Ukraine/uk-UA that referenced this pull request Jan 15, 2024
joomla/joomla-cms#42387 +
joomla/joomla-cms#42574 - (тільки для en-GB)
+ виправлення помилок, покращення та відподвідність іншим файлам стосовно
формулювання у файлах XML, редакторі TinyMCE, файлі встановлення Joomla
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants