[5.0] Update composer dependency maximebf/debugbar to v1.19.0#41932
Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom Sep 26, 2023
Merged
[5.0] Update composer dependency maximebf/debugbar to v1.19.0#41932HLeithner merged 1 commit intojoomla:5.0-devfrom
HLeithner merged 1 commit intojoomla:5.0-devfrom
Conversation
Member
|
thanks |
2 tasks
HLeithner
pushed a commit
to HLeithner/joomla-cms
that referenced
this pull request
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
In the 4.4-dev branch we currently have in composer.json
"maximebf/debugbar": "dev-master". This resolves in commit "30f65f18f7ac086255a77a079f8e0dcdd35e828e" in the lock file. This commit belongs to their version "1.19.0".In the 5.0-dev branch we have in composer.json
"maximebf/debugbar": "^1.18.2", which results in version "1.18.2" being used, which is the version before the "1.19.0", see php-debugbar/php-debugbar@v1.18.2...v1.19.0 .That means that when we currently update the CMS from 4.4 to 5, we downgrade the "maximebf/debugbar" dependency.
This PR here fixes that by updating the maximebf/debugbar dependency to version "1.19.0" here in the 5.0-dev branch, together with a PR for 4.4-dev to change there from
"dev-master"to"^1.19.0", too.The PR here might become obsolete when the other one has been merged into 4.40-dev and that has been upmerged to 5.0-dev then. But it can be used to check the result of that.
Testing Instructions
Check that the debug bar works.
Actual result BEFORE applying this Pull Request
Works.
Expected result AFTER applying this Pull Request
Still works.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed