[5.0] Fix color of icon in dark mode#41919
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Sep 26, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 7f01e34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 7f01e34 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41919. |
Member
|
Thx |
HLeithner
pushed a commit
to HLeithner/joomla-cms
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Quy <quy@nomonkeybiz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41818 .
Summary of Changes
Changes the icon color to reflect text color and removes the near invisible backgroundl
Testing Instructions
Check icon dashboard per original issue in both light and dark mode. The light mode will change color a fraction but shouldn't be significantly noticeable.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed