[5.0] Fix user group deletion events compatibility#41916
Merged
HLeithner merged 5 commits intojoomla:5.0-devfrom Sep 25, 2023
Merged
[5.0] Fix user group deletion events compatibility#41916HLeithner merged 5 commits intojoomla:5.0-devfrom
HLeithner merged 5 commits intojoomla:5.0-devfrom
Conversation
Member
|
Please introduce new extended classes for before and after, we don't know how long we really have this event and as you did it now you just pollute the constructor used for all other events |
Member
Author
|
Changed |
Member
|
I have tested this item ✅ successfully on 1cf9784 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41916. |
Member
|
thanks |
HLeithner
added a commit
to HLeithner/joomla-cms
that referenced
this pull request
Sep 26, 2023
* Fix user group deletion events compatibility * Fix user group deletion events compatibility * Fix user group deletion events compatibility * Fix user group deletion events compatibility --------- Co-authored-by: Harald Leithner <leithner@itronic.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41906 .
Summary of Changes
Fix event compatibility for UserGroupDelete events
Testing Instructions
Try delete User group
Actual result BEFORE applying this Pull Request
An error
Expected result AFTER applying this Pull Request
Group is deleted without error
Link to documentations
Please select: