[5.0] Remove 'track_errors' and $php_errormsg#41908
Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom Sep 25, 2023
Merged
[5.0] Remove 'track_errors' and $php_errormsg#41908HLeithner merged 3 commits intojoomla:5.0-devfrom
HLeithner merged 3 commits intojoomla:5.0-devfrom
Conversation
Member
HLeithner
reviewed
Sep 25, 2023
HLeithner
reviewed
Sep 25, 2023
Contributor
Author
|
@HLeithner All done. |
Member
|
thanks I merged this for now so we have it in beta3. CI test should at least check the language parsing part. thanks |
4 tasks
HLeithner
pushed a commit
to HLeithner/joomla-cms
that referenced
this pull request
Sep 26, 2023
* remove track_errors * cs * Revert $fileName and weird stringified key access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41889 #25789 #17856 #33185
Summary of Changes
Remove suppressing of methods which produce E_WARNING and necessity of catching the error in deprecated
$php_errormsg.I didn't update
Joomla\CMS\Filesystem\Streambecause it's deprecated since 4.4Testing Instructions
Try to parse language string with errors (with enabled Joomla debug + language debug)
Try to install the package from invalid URL
Actual result BEFORE applying this Pull Request
See native Joomla error messages in installer and debug errors in language debug bar.
Expected result AFTER applying this Pull Request
See the same errors/messages.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed