[5.0] Rename media manager CSS Vars and move to dedicated file#41903
Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom Sep 26, 2023
Merged
[5.0] Rename media manager CSS Vars and move to dedicated file#41903HLeithner merged 1 commit intojoomla:5.0-devfrom
HLeithner merged 1 commit intojoomla:5.0-devfrom
Conversation
Member
|
computer says no, please fix cs |
ae9d661 to
08bb6fa
Compare
Contributor
Author
|
Fixed CS and rebased |
Member
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This implements the naming conventions agreed on in the maintainers last meeting. Not sure it's been published yet so attached below for those wondering:
Additionally it adds a CSS var that I missed when moving all the variables into the media manager _variables file and moves com_media ones into a dedicated file as this seemed to be preferred when comparing the media and calendar implementations.
Testing Instructions
No visible changes
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed