[5.0] build tools creates wrong folder#41321
Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom Aug 11, 2023
Merged
Conversation
Contributor
|
LGTM |
Member
|
I have tested this item ✅ successfully on 263c4da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321. |
Member
|
@dgrammatiko Could you do a real test, too? Thanks in advance. |
Contributor
|
@richard67 I'm mostly on my phone these days and I don't have Codespaces enabled for Joomla, so kinda hard atm... sorry |
Contributor
|
I have tested this item ✅ successfully on 263c4da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321. |
Member
|
thanks |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
* [5.0] build tools creates wrong folder * update/sync incompatible.html --------- Co-authored-by: Quy <quy@nomonkeybiz.com>
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 5, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
includes/incompatible.htmlby runnpm ciTesting Instructions
check items of
templates\systemActual result BEFORE applying this Pull Request
a new folder (including a sub folder) is created by the build tools for error pages
Expected result AFTER applying this Pull Request
no extra folder like 4.3, 4.4
Link to documentations
Please select: