[5.0] Fix excluded files from PR #41065#41207
Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom Jul 22, 2023
Merged
Conversation
Member
|
thanks |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for #41065 (comment) .
Summary of Changes
This Pull Request (PR) fixes a mistake in the
build/deleted_file_check.phpscript which I've made with my recently merged PR #41065 :The files
administrator/language/en-GB/plg_task_demotasks.iniandadministrator/language/en-GB/plg_task_demotasks.sys.inishould be excluded from the list of deleted files, but that doesn't work because I've added them at the wrong place.Testing Instructions
tmpfolder:tmpfolder into 2 separate foldersJoomla_5.0.0-alpha1-Alpha-Full_PackageandJoomla_5.0.0-alpha2-Alpha-Full_Package.\instead of slashes/for the paths):./build/deleted_files.txtand./build/deleted_folders.txt.Result: See section "Actual result BEFORE applying this Pull Request" below.
Result: See section "Expected result AFTER applying this Pull Request" below.
Actual result BEFORE applying this Pull Request
File
./build/deleted_files.txtstill contains 2 rows'/administrator/language/en-GB/plg_task_demotasks.ini',and'/administrator/language/en-GB/plg_task_demotasks.sys.ini',.File
./build/deleted_folders.txtis empty.Expected result AFTER applying this Pull Request
File
./build/deleted_files.txtdoesn't contain'/administrator/language/en-GB/plg_task_demotasks.ini',and'/administrator/language/en-GB/plg_task_demotasks.sys.ini',.Besides that, it doesn't differ to the file saved in step 5 without this PR applied.
File
./build/deleted_folders.txtis empty, same as without this PR.Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed