[5.0] Delete 4.x update SQL scripts from last upmerge and add them to deleted files list in script.php#40372
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Apr 12, 2023
Conversation
Member
Author
|
Ping @HLeithner . Question: Would it help to add the patterns |
Member
I think it's better to keep it as it is, because we need to delete the files in this script file anyway. Maybe a notice/warning/error in the build script could make sense. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
May 29, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 8, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jun 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 22, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 23, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 5, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 5, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
With the last upmerge from 4.4-dev there have been again added new 4.x update SQL scripts to the 5.0-dev branch.
These files should not be merged up.
This PR here fixes that by deleting the files and adding them to the list of deleted files in script.php so they are deleted when updating from 4.x like it is done with the other 4.x update SQL scripts.
Currently there are no other changes to be done on the deleted files and folders lists in script.php in the 5.0-dev branch.
Testing Instructions
Code review.
Or if you want to make a real test, update the last 4.4 nightly build to the last 5.0 nightly build to get the actual result, and update the last 4.4 nightly build to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
There are two 4.3.0 update SQL scripts present for each kind of database after updating from the last 4.4 nightly build.
Expected result AFTER applying this Pull Request
There are no 4.x update SQL scripts present after updating from the last 4.4 nightly build.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed