[5.0] Chore/disable polyfill php 7.0 - 8.1#40293
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Apr 2, 2023
Merged
Conversation
Contributor
|
121 changed files ? |
Member
Author
Contributor
|
The changes look ok but please - one commit per issue. Nothing is really testable when you lump so many things into one pr |
Member
Author
|
I try to reduce merge conflicts, pr based on other prs is a common case, and as soon as the other pr is merged this one get cleared automatically. |
Contributor
|
I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes |
Member
Author
do you understand it now? after merging the upmerge pr, this PR is clean and has only the commits related for this pr |
Contributor
|
I understood it before - I still dont think it is good practice. Also due to language issues I read your comment "based on" to mean the code in this pr is based on the same techniques in this other PR. |
Member
|
Was just preparing my tests. |
Member
|
Test was successful, PR solves the problem. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 2, 2023
2 tasks
HLeithner
pushed a commit
that referenced
this pull request
Apr 3, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 30, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jul 24, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 12, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Aug 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 4, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 5, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 5, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 14, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 19, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Sep 26, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need the symfony polyfills for php < 8.2 since the php minimum requirement is 8.1
This PR is based on #40292