[4.4] Replace JPATH_PLATFORM with _JEXEC in plugin code#40232
Merged
laoneo merged 6 commits intojoomla:4.4-devfrom Mar 29, 2023
Merged
[4.4] Replace JPATH_PLATFORM with _JEXEC in plugin code#40232laoneo merged 6 commits intojoomla:4.4-devfrom
laoneo merged 6 commits intojoomla:4.4-devfrom
Conversation
Member
|
Just wondering, do we have more occurrences of JPATH_PLATFORM or are these the last ones? |
Contributor
Author
I have checked the plugin code in Joomla 4.4. The modules (site) are up to date. I assume the libraries folder is not applicable. Is this correct? If yes, then there are still about 24 in the folder \administrator\components... |
Contributor
|
Good idea, looks ok to me |
Member
|
So we can do in a followup pr a replacement of all JPATH_PLATFORM... |
Member
|
Thanks! |
Contributor
Author
|
Thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The constant
JPATH_PLATFORMis a history thing and should not be used in the plugin codeThis pr replaces this with
_JEXEC, and makes the code consistent with that of the other plugins.Related to #39997
Testing Instructions
Actual result BEFORE applying this Pull Request
Code:
\defined('JPATH_PLATFORM') or die;Expected result AFTER applying this Pull Request
Code:
\defined('_JEXEC') or die;Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@laoneo please take a look