[4.3] Replace JPATH_PLATFORM with _JEXEC in dispatcher.php#39997
Merged
obuisard merged 7 commits intojoomla:4.3-devfrom Mar 8, 2023
Merged
[4.3] Replace JPATH_PLATFORM with _JEXEC in dispatcher.php#39997obuisard merged 7 commits intojoomla:4.3-devfrom
obuisard merged 7 commits intojoomla:4.3-devfrom
Conversation
4 tasks
Contributor
|
I have tested this item ✅ successfully on fe6ebbe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997. |
Contributor
Author
We will see and wait. |
wilsonge
approved these changes
Mar 4, 2023
Contributor
|
I have tested this item ✅ successfully on fe6ebbe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997. |
Contributor
|
RTC.Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39997. |
Contributor
|
Thank you @sandewt for the PR! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The constant JPATH_PLATFORM is a history thing and should not be used for new code in
Dispatcher.phpThis pr replaces this with _JEXEC in some files
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Code:
\defined('JPATH_PLATFORM') or die;Expected result AFTER applying this Pull Request
Code:
\defined('_JEXEC') or die;Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@joomdonation