[6.0] Notification email on admin registration approval#39650
[6.0] Notification email on admin registration approval#39650carlitorweb wants to merge 36 commits intojoomla:6.0-devfrom
Conversation
|
/me dancing with joy |
administrator/components/com_users/src/Controller/UserController.php
Outdated
Show resolved
Hide resolved
administrator/components/com_users/src/Controller/UserController.php
Outdated
Show resolved
Hide resolved
administrator/components/com_users/src/Controller/UserController.php
Outdated
Show resolved
Hide resolved
…er.php Co-authored-by: Brian Teeman <brian@teeman.net>
…er.php Co-authored-by: Brian Teeman <brian@teeman.net>
…er.php Co-authored-by: Brian Teeman <brian@teeman.net>
|
or maybe the issue is that its not using the mail template |
|
My bad, I totally forgot the "mail sent" notification. The other issue is weird, that worked for me in local. I will do a fresh Joomla install and check from there, maybe I had some changes made in the repo I was using...but still weird, somehow the mailer is not loading the strings.. I will check later this |
|
@brianteeman Okay you was right, the com_users.ini language loaded was only from the administrator part, as is expected. So adding the follow: // Load com_users site language strings
$language = $app->getLanguage();
$language->load('com_users', JPATH_SITE);Fix the problem. But I really not like this solution. The best approch is just copy the strings to the administrator .ini language file. Is okay do it like this? |
|
How do the other com_users admin emails do it? |
I using it, yes: $mailer = new \Joomla\CMS\Mail\MailTemplate('com_users.registration.user.admin_activated', $app->getLanguage()->getTag());
$mailer->addTemplateData($mailData);
$mailer->addRecipient($userMail);
They have all the string in the administrator .ini file |
administrator/components/com_users/src/Controller/UserController.php
Outdated
Show resolved
Hide resolved
…er.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…er.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
@carlitorweb resolving the 2 conversations is needed before a test? |
yes, working on it |
|
Okay, I think is ready. |
|
@carlitorweb thanks for your work. I'm unable to get an email (verification link) after the registration is send. In "Global Configuration > Server > Mail – Send Test Mail" no E-Mail arrived. The Button "Activate and send e-mail" seems to work and changed to "Send Activation Reminder". Sorry, no test. For other test user: To be able to create a user account in the Frontend you have to open "User Options > Allow User Registration – Yes". Test System Information: |
|
This pull request has been automatically rebased to 5.3-dev. |
|
This pull request has been automatically rebased to 6.0-dev. |
|
Looks like with all the rebases something has broken in this PR. Would love to see this in j6 |
|
I have rebuilt this PR so that it can be tested #45802 |
|
Closing in favour of @45802 . Thanks @carlitorweb . |

This is a rework for j4 of this PR #20282
Summary of Changes
The user who are manually actived will receive a notification by email informing his account has been activated.
There is also the option of being able to manually send a reminder email to the user even though the account is already activated (in case the user do not login in the page after X time)
The mail template used is
com_users.registration.user.admin_activatedTesting Instructions
Apply the PR and after run
npm run build:js -- build/media_source/com_users/jsActual result BEFORE applying this Pull Request
You can active a user, but not notification is sent.
Expected result AFTER applying this Pull Request
You can active a user, but a notification is sent.
Accept suggestions for:
Link to documentations
Please select:
Documentation link for docs.joomla.org
Page: Users:_Edit_Profile -> Document the new toolbar button
Page: Users -> Here just need mention that active the user will send a email with the notification.
No documentation changes for manual.joomla.org needed