Notification email on admin registration approval by carlitorweb · Pull Request #20282 · joomla/joomla-cms

carlitorweb · 2018-05-02T13:18:55Z

Pull Request for Issue #13620

Summary of Changes

Sending a notification email, after an Admin activate a user/users, on the user's list of com_users

Testing Instructions

Register as a new user
Go to the Users list inside the administration, and activate the user/users
Check the email is sent to the user, notifying him that it has been approved on the site

Edit a user that is not activated
Press the button you will find under the Account Details tab
Check the user is activated and an email is sent for notifying him that it has been approved on the site

Edit a user that is activated, but that has not yet entered in the site for the first time
Check the same button is there under the Account Details tab, and press it
Check an email is sent for notifying him that it has been approved on the site

Expected result

An email is sent to the user, notifying him that it has been approved on the site

Actual result

The user is activated but is not notified of this change

Request for feedback (SOLVED)

This change also requires that within the user edit view, a button appears that allows an administrator to activate the user from there.

For this, I added a new radio field "activation" for handle this under Accounts Details, but this field store a hash when the user It is registered in the site then this new field is not convenient.

I can create a new field under the params fields, and handle this as a param, but I not think this need be under the Basic Settings tab.

So, my doubt is, What is the best way to treat this?

Documentation Changes Required

New com_users.user button added.
Now when you activate a user on com_users list, send an email

brianteeman · 2018-05-02T13:28:37Z

why not a simple button that "activates" the user and "sends the email" - something like here (ignore the extra tabs)

carlitorweb · 2018-05-02T13:35:25Z

That is a good point @brianteeman . Thank you. I will work on that way.

brianteeman · 2018-05-02T13:38:51Z

@carlitorweb you might find the second half of this blog post (and the comments) useful https://brian.teeman.net/joomla/870-authorising-and-approving-joomla-users

Thanks for working on this

carlitorweb · 2018-05-02T13:58:54Z

Really have good comments that blog post. Carlos found an easy and good way for this https://github.com/carcam/plg_user_sendactivationmail/blob/master/sendactivation/sendactivationmail.php .
But that comment about map this button with both actions, "activation" AND "resend email sound good too.

Quy · 2018-05-03T15:32:40Z

administrator/components/com_users/views/user/tmpl/edit.php

 							<?php echo $field->input; ?>
+							<?php // If the user has not logged into the site for the first time, then either an administrator has not activated it ?>
+							<?php // Or in some way the notification mail has not been received yet ?>
+							<?php if($field->fieldname == 'name' && $this->form->getValue('lastvisitDate') === JFactory::getDbo()->getNullDate()) : ?>


Add space after if

Quy · 2018-05-03T15:33:28Z

administrator/components/com_users/controllers/user.php

+	{
+		// Check for request forgeries.
+		JSession::checkToken() or jexit(JText::_('JINVALID_TOKEN'));		
+


Remove tabs

Quy · 2018-05-03T15:33:38Z

administrator/components/com_users/controllers/user.php

+	public function activate()
+	{
+		// Check for request forgeries.
+		JSession::checkToken() or jexit(JText::_('JINVALID_TOKEN'));		


Remove trailing tabs

Also line 99 with trailing tabs.

Quy · 2018-05-03T15:34:03Z

administrator/components/com_users/models/user.php

 	{
 		$dispatcher = JEventDispatcher::getInstance();
 		$user       = JFactory::getUser();
+		$config 	= JFactory::getConfig();


carlitorweb · 2018-05-03T15:41:39Z

@brianteeman what you think? (the warning: Could not start mail function, is because of a wrong config on my local)
Thank @Quy

brianteeman · 2018-05-03T15:53:50Z

I'm on my phone but the button says send email? And it activates and sends email?

If so then I personally would just call the button "activate"

To me that would be the expected behaviour

carlitorweb · 2018-05-03T15:57:26Z

Yes, send email, but active at same time, because if send an email saying to the user can log in now, then that user need be activated for that.

carlitorweb · 2018-05-03T16:31:54Z

Done. Thank again @Quy

Quy · 2018-05-04T21:17:45Z

administrator/components/com_users/models/user.php

 	{
 		$dispatcher = JEventDispatcher::getInstance();
-		$user       = JFactory::getUser();
+		$user 		= JFactory::getUser();


brianteeman · 2018-05-05T07:32:23Z

I still think the text on the button is a little unclear

The admin might think that they have to scroll down and click activate (like they did before) and then click on the button to send the email.

When in fact the button (correctly) does both. So I would prefer something like
"Activate and send email"

brianteeman · 2018-05-05T07:33:22Z

administrator/language/en-GB/en-GB.com_users.ini

 COM_USERS_USER_OTEPS="One time emergency passwords"
 COM_USERS_USER_OTEPS_DESC="If you do not have access to your two factor authentication device you can use any of the following passwords instead of a regular security code. Each one of these emergency passwords is immediately destroyed upon use. We recommend printing these passwords out and keeping the printout in a safe and accessible location, eg your wallet or a safety deposit box."
 COM_USERS_USER_OTEPS_WAIT_DESC="There are no emergency one time passwords generated in your account. The passwords will be generated automatically and displayed here as soon as you activate two factor authentication."
+COM_USERS_USER_RESEND_BUTTONTEXT="Resend a notification email"


==> "Resend activation email"

carlitorweb · 2018-05-05T20:05:29Z

This commit performs this task through ajax. In this way, the user no need redirect to the com_users list. I will fix the drone errors

brianteeman · 2020-02-10T12:49:17Z

It would be really great if someone could port this to joomla 4

Quy · 2020-02-10T18:31:04Z

Removed RTC. To be rebased for J4.

ashvini77 · 2020-11-07T10:59:46Z

Error "The file marked for modification does not exist: administrator/components/com_users/controllers/user.php" displayed on applying the patch

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20282.}

brianteeman · 2020-11-07T11:15:20Z

@ashvini77 This PR is for Joomla 3 were you testing on Joomla 4?

zero-24 · 2021-08-08T21:09:48Z

Dear @carlitorweb

in preperation of the upcomming release of Joomla 3.10 we have used GitHubs rename feature to rename the staging branch into 3.10-dev. Usually GitHub moves all existing PRs towards the new branch just fine, but here it didnt work. The reason seems to be that the fork of the CMS that was used as base for this PR has been deleted so GitHub does no longer have a base to rebase the PR against the new branch and we are also not able to reopen the PR. For that reason GitHub closed this PR in my name, when this issue is still valid It would require a new PR against the new 3.10-dev or 4.0-dev branch.

carlitorweb · 2021-08-12T15:38:47Z

@zero-24 Understood. And is correct I deleted that fork. If this PR is still considered, what should I do?

zero-24 · 2021-08-12T16:00:25Z

When this is still a feature you would like to have please create a PR against 4.1-dev so it can be tested and @bembelimen can take it into 4.1.

jjnxpct · 2023-05-31T09:45:27Z

Is this feature still being worked on? I have I site where this 'send registration email' button could be very useful ;-)

mgretz · 2023-10-20T10:02:03Z

We would also appreciate a working solution for this.

brianteeman · 2023-10-20T10:18:20Z

I am using this plugin now https://github.com/Spudley/plg_user_notifyactivation

tschombes · 2024-01-17T13:34:28Z

Still an issue in Joomla 5.x

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20282.}

Send email notification on users list

d7f97d6

joomla-cms-bot added the PR-staging label May 2, 2018

ghost mentioned this pull request May 2, 2018

No email on admin registration approval in some cases #13620

Closed

Send email notification on user view

95e7ca3

carlitorweb requested a review from brianteeman as a code owner May 3, 2018 15:12

joomla-cms-bot added the Language Change This is for Translators label May 3, 2018

carlitorweb added 2 commits May 3, 2018 11:12

Send email notification on user view

42885e7

Changing comments style

3812a41

Quy reviewed May 3, 2018

View reviewed changes

Code review

97563cc

Code review

da3a151

carlitorweb added 2 commits May 3, 2018 12:33

Code review

c502f88

Button style

2fa8f3d

Quy reviewed May 4, 2018

View reviewed changes

brianteeman reviewed May 5, 2018

View reviewed changes

Perform the task as a ajax request

4ff026f

drone fix

3c1eb79

ghost added the J4 Rebase label Jun 16, 2019

Merge branch 'staging' into email_admin_registration

bfd5353

Quy removed PR-staging RTC This Pull Request is Ready To Commit labels Jul 5, 2019

N8Solutions mentioned this pull request Feb 2, 2020

New User Account Activation fails when, in the Global Configuration, New User Account Activation is set to "Admin" and when the "Access" level for the "Login" & "Register" menu items is set to "Guest". #27774

Closed

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 10, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 10, 2020

wilsonge self-assigned this Feb 17, 2020

brianteeman mentioned this pull request May 20, 2020

User activation process optimization #29170

Closed

brianteeman mentioned this pull request Jul 28, 2021

[3.9] [J4] [J5] No activation email is sent when admin activates user in backend #34956

Closed

zero-24 deleted the branch joomla:staging August 8, 2021 20:08

zero-24 closed this Aug 8, 2021

carlitorweb mentioned this pull request Jan 16, 2023

[6.0] Notification email on admin registration approval #39650

Closed

2 tasks

jjnxpct mentioned this pull request Feb 19, 2025

User activation link in admin email does not work #44732

Closed

Uh oh!

Conversation

carlitorweb commented May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Request for feedback (SOLVED)

Documentation Changes Required

Uh oh!

brianteeman commented May 2, 2018

Uh oh!

carlitorweb commented May 2, 2018

Uh oh!

brianteeman commented May 2, 2018

Uh oh!

carlitorweb commented May 2, 2018

Uh oh!

Quy May 3, 2018

Choose a reason for hiding this comment

Uh oh!

Quy May 3, 2018

Choose a reason for hiding this comment

Uh oh!

Quy May 3, 2018

Choose a reason for hiding this comment

Uh oh!

Quy May 3, 2018

Choose a reason for hiding this comment

Uh oh!

Quy May 3, 2018

Choose a reason for hiding this comment

Uh oh!

carlitorweb commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented May 3, 2018

Uh oh!

carlitorweb commented May 3, 2018

Uh oh!

carlitorweb commented May 3, 2018

Uh oh!

Quy May 4, 2018

Choose a reason for hiding this comment

Uh oh!

brianteeman commented May 5, 2018

Uh oh!

brianteeman May 5, 2018

Choose a reason for hiding this comment

Uh oh!

carlitorweb commented May 5, 2018

Uh oh!

brianteeman commented Feb 10, 2020

Uh oh!

Quy commented Feb 10, 2020

Uh oh!

ashvini77 commented Nov 7, 2020

Uh oh!

brianteeman commented Nov 7, 2020

Uh oh!

zero-24 commented Aug 8, 2021

Uh oh!

carlitorweb commented Aug 12, 2021

Uh oh!

zero-24 commented Aug 12, 2021

Uh oh!

jjnxpct commented May 31, 2023

Uh oh!

mgretz commented Oct 20, 2023

Uh oh!

brianteeman commented Oct 20, 2023

Uh oh!

tschombes commented Jan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

carlitorweb commented May 2, 2018 •

edited

Loading

carlitorweb commented May 3, 2018 •

edited

Loading