Skip to content

[4.3] add missing deprecated note for #39453#39619

Merged
obuisard merged 1 commit intojoomla:4.3-devfrom
tecpromotion:fix-unused-string-39453
Jan 13, 2023
Merged

[4.3] add missing deprecated note for #39453#39619
obuisard merged 1 commit intojoomla:4.3-devfrom
tecpromotion:fix-unused-string-39453

Conversation

@tecpromotion
Copy link
Copy Markdown
Contributor

@tecpromotion tecpromotion commented Jan 13, 2023

Pull Request addon for PR #39453 .

Summary of Changes

With PR #39453, the two strings COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_DESC and COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_LABEL were deleted in the config and designated as deprecated in the administrator ini file.
The deprecated note is missing in the frontend language file.

This PR also adds the message in the frontend ini file.

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_DESC="A comma separated list of forbidden MIME types to upload."
COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_LABEL="Forbidden MIME Types"

Expected result AFTER applying this Pull Request

; Deprecated, will be removed with 5.0
COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_DESC="A comma separated list of forbidden MIME types to upload."
; Deprecated, will be removed with 5.0
COM_MEDIA_FIELD_ILLEGAL_MIME_TYPES_LABEL="Forbidden MIME Types"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@tecpromotion
fix unused string
8d1ea2f 
add Deprecated warning
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Jan 13, 2023
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jan 13, 2023

I have tested this item ✅ successfully on 8d1ea2f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39619.

1 similar comment
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jan 13, 2023

I have tested this item ✅ successfully on 8d1ea2f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39619.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 13, 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39619.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 13, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 13, 2023
@obuisard obuisard merged commit 5dbdf23 into joomla:4.3-dev Jan 13, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 13, 2023
@obuisard
Copy link
Copy Markdown
Contributor

obuisard commented Jan 13, 2023

Thank you, Stefan @tecpromotion !

@jgerman-bot jgerman-bot mentioned this pull request Jan 14, 2023
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Jan 14, 2023
Closed
@tecpromotion tecpromotion deleted the fix-unused-string-39453 branch August 31, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tecpromotion @brianteeman @laoneo @Quy @obuisard @joomla-cms-bot