Skip to content

[4] Remove unused com_media field "upload_mime_illegal"#39453

Merged
obuisard merged 3 commits intojoomla:4.3-devfrom
ReLater:patch-3
Jan 12, 2023
Merged

[4] Remove unused com_media field "upload_mime_illegal"#39453
obuisard merged 3 commits intojoomla:4.3-devfrom
ReLater:patch-3

Conversation

@ReLater
Copy link
Copy Markdown
Contributor

@ReLater ReLater commented Dec 20, 2022 •
edited by obuisard
Loading

All credits to @Kostelano . I only took over his closed pr #39196

Closes #38280

Summary of Changes

  • Remove field upload_mime_illegal from com_media settings.
  • Deprecate associated language strings.

Testing Instructions

Actual result BEFORE applying this Pull Request

  • Settings ignored on file uploads in media manager.

Expected result AFTER applying this Pull Request

  • No change. Settings ignored on file uploads in media manager.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Dec 20, 2022
@ReLater ReLater changed the title WIP!! config.xml. Remove field upload_mime_illegal [4] Remove unused com_media field "upload_mime_illegal" Dec 20, 2022
This was referenced Dec 20, 2022
Closed
Closed
@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Dec 20, 2022

I have tested this item ✅ successfully on ee05408

J 4.2.7-dev

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

@viocassel
Copy link
Copy Markdown
Contributor

viocassel commented Dec 20, 2022

I have tested this item ✅ successfully on ee05408

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

@richard67 richard67 removed the Language Change This is for Translators label Dec 21, 2022
@richard67
Copy link
Copy Markdown
Member

richard67 commented Dec 21, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39453.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 21, 2022
@richard67 richard67 added the Language Change This is for Translators label Dec 21, 2022
@ReLater
Copy link
Copy Markdown
Contributor Author

ReLater commented Dec 29, 2022

I don't know what

Documentation link for docs.joomla.org

means. I have adapted https://docs.joomla.org/Help4.x:Media:_Options , but ????

@carlitorweb
Copy link
Copy Markdown
Member

carlitorweb commented Jan 12, 2023

Documentation changed ✔️ (https://docs.joomla.org/Help4.x:Media:_Options)

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 12, 2023
@obuisard obuisard merged commit ca4a46b into joomla:4.3-dev Jan 12, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@obuisard
Copy link
Copy Markdown
Contributor

obuisard commented Jan 12, 2023

Thank you @ReLater for the PR!

@ReLater ReLater deleted the patch-3 branch January 12, 2023 09:08
@jgerman-bot jgerman-bot mentioned this pull request Jan 13, 2023
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Jan 13, 2023
Closed
@tecpromotion tecpromotion mentioned this pull request Jan 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation Required Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 4.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@ReLater @ChristineWk @viocassel @richard67 @carlitorweb @obuisard @joomla-cms-bot