Newsflash module change name of style#39585
Merged
roland-d merged 1 commit intojoomla:4.2-devfrom Jan 10, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 010470b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585. |
Contributor
|
I have tested this item ✅ successfully on 010470b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39585. |
Contributor
|
Thank you |
Collaborator
Author
|
Thanks! |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #39584 .
Summary of Changes
Changed the name of the styles for the web assets manager to avoid overwriting if several modules are present on a page.
Testing Instructions
Create two newsflash modules, one with horizontal and one with vertical layout.
See issue for more details.
Actual result BEFORE applying this Pull Request
If the vertical layout is loaded as latest the module with the horizontal layout will be also displayed as vertical, because the css is missing.
Expected result AFTER applying this Pull Request
Horizontal layout won't be overwritten by the vertical module.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed