[4.2] Clean the logo URL in Atum#39579
Merged
roland-d merged 5 commits intojoomla:4.2-devfrom Jan 9, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 53821a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 53821a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39579. |
Contributor
|
Thank you |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
* Clean the logo URL * fix the logos * meh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request is the same bug fix as #39574
Summary of Changes
Use the recommended way to render an image: through the HTMLHelper
Testing Instructions
Check that selecting a custom logo image works and that the source doesn't have the hash part of the URL. Also check that svg renders as expected
Actual result BEFORE applying this Pull Request
The URL contains the hash (it is dirty) and SVG images get 0 width and height thus are not visible
Expected result AFTER applying this Pull Request
The URL does not contain the hash (it is clean) and SVG images are visible
Link to documentations
This is a bug fix without changing any of the existing functionality
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed