Skip to content

[4.2] Fix Feature start and end date on category blog#39572

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
joomdonation:fix_category_blog_featured
Jan 9, 2023
Merged

[4.2] Fix Feature start and end date on category blog#39572
roland-d merged 2 commits intojoomla:4.2-devfrom
joomdonation:fix_category_blog_featured

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

Pull Request for Issue #39562.

Summary of Changes

This PR fixes feature start and end date don't affect blog view as described in the issue #39562 . Please read the issue description to understand more about it if needed.

Testing Instructions

  1. Use Joomla 4.2
  2. Create an article, set Featured to Yes, but Start Featured is greater than current date or Finish Featured is less than current date (or both). So the article is marked as featured but it is not really featured for the moment of testing.
  3. Create a menu item to link to Category Blog menu item type. Select the category which the article belongs to in the menu item parameter. In Blog Layout tab of the menu item, set Featured Articles parameter to Hide
  4. Access to that menu item

Actual result BEFORE applying this Pull Request

The article is not being displayed.

Expected result AFTER applying this Pull Request

The article is now being displayed. It is correct behavior because at the moment of testing, it is not featured (current time is not in the featured duration settings controlled by Start Featured and Finish Featured).

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@Harmageddon
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c7f35b0

Works as expected and consistent with the other views (category blog with featured: only and featured page). Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39572.

@chmst chmst added the Maintainers Checked Used if the PR is conceptional useful label Jan 8, 2023
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c7f35b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39572.

@Quy Quy removed the Maintainers Checked Used if the PR is conceptional useful label Jan 9, 2023
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39572.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@roland-d roland-d merged commit c071cbb into joomla:4.2-dev Jan 9, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jan 9, 2023

Thank you

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 9, 2023
@joomdonation joomdonation deleted the fix_category_blog_featured branch January 9, 2023 18:54
charvimehradu pushed a commit to charvimehradu/joomla-cms that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants