Skip to content

Fixed select colour bleed (ultrawide screens)#39569

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
JackKellyUK:select-colour-bleed
Jan 9, 2023
Merged

Fixed select colour bleed (ultrawide screens)#39569
roland-d merged 2 commits intojoomla:4.2-devfrom
JackKellyUK:select-colour-bleed

Conversation

@JackKellyUK
Copy link
Copy Markdown
Contributor

@JackKellyUK JackKellyUK commented Jan 7, 2023

Pull Request for Issue #34682.

Summary of Changes

Adjusted select background size to prevent bleeding.

Testing Instructions

  1. Login to the Joomla 4 backend
  2. Go to Components -> Banners
  3. Create a new banner
  4. Click on the banner details tab
  5. Increase screen dimensions to atleast 2400px

Actual result BEFORE applying this Pull Request

Background on selects begin to bleed at ~ 2400px
image

Expected result AFTER applying this Pull Request

Backgrounds no longer bleed on selects at ~ 2400px+
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jan 7, 2023
@JackKellyUK
Copy link
Copy Markdown
Contributor Author

Dont have UWS, but setting max to 100% seems reasonable :)

I don't think you need an ultrawide to test, you should be able to set screen dimensions in your browsers dev tools.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 8e17ce4

tested successfully in both LTR and RTL


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 8e17ce4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jan 9, 2023
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39569.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jan 9, 2023
@roland-d roland-d merged commit b1963b8 into joomla:4.2-dev Jan 9, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jan 9, 2023

Thank you

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 9, 2023
charvimehradu pushed a commit to charvimehradu/joomla-cms that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants