[4.2] Fix move user to group#39483
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Dec 28, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on e3326d8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483. |
1 similar comment
|
I have tested this item ✅ successfully on e3326d8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The feature to move an user to a group is broken after #38596.
Variable
$usersis not assigned in this if-case. Use the correct variable$userIdslike it was before #38596joomla-cms/administrator/components/com_users/src/Model/UserModel.php
Lines 725 to 727 in f520c98
Testing Instructions
Try moving a user to a group using the batch command.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
The user is moved to the new group.
Link to documentations
Please select: