[4.2] Minor patch for the currentModal#39450
Merged
fancyFranci merged 3 commits intojoomla:4.2-devfrom Jan 10, 2023
Merged
Conversation
4 tasks
Member
|
Please update also the incorrect comment joomla-cms/build/media_source/system/js/core.es6.js Lines 114 to 118 in 6cd61cb It should be used Joomla.Modal.getCurrent(). |
Contributor
Author
|
@Fedik done |
Fedik
approved these changes
Dec 19, 2022
Member
|
Remember for the other tester use after apply the patch, |
Member
|
I have tested this item ✅ successfully on 385efc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 385efc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39450. |
Contributor
|
Thanks for cleaning this up! |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Joomla.currentinstead ofJoomla.Modal.currentJoomla.currentis not referenced by any other API, but it shouldn't be used for the modalsTesting Instructions
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed