Disable parent on the fly for tags#39443
Merged
fancyFranci merged 5 commits intojoomla:4.2-devfrom Jan 10, 2023
Merged
Conversation
Contributor
Contributor
Author
|
Agree, The tag field should behave like the categoryedit field. At the moment it os not clear how the categoryedit field should work see #39440. I don't mind to close this one and re-open the issue. Unfortunately don't have time for diving deeper into nested set. |
Contributor
|
I have tested this item ✅ successfully on 922e402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443. |
Contributor
|
I have tested this item ✅ successfully on 922e402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443. |
Contributor
|
Great, thank you! |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request for Issue #39441
Summary of Changes
This PR disables the input of a new tag in the parent field on com_tags edit.
Testing Instructions
see #39441
Ty to add a new tag in the parent selection field.
Actual result BEFORE applying this Pull Request
see #39441
Expected result AFTER applying this Pull Request
The parent tag allows seleting a tag as parent but does not accept the input of a new tag name.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed