Skip to content

Disable parent on the fly for tags#39443

Merged
fancyFranci merged 5 commits intojoomla:4.2-devfrom
chmst:tags-disable-parent-on-the-fly
Jan 10, 2023
Merged

Disable parent on the fly for tags#39443
fancyFranci merged 5 commits intojoomla:4.2-devfrom
chmst:tags-disable-parent-on-the-fly

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Dec 18, 2022

Pull Request for Issue #39441

Summary of Changes

This PR disables the input of a new tag in the parent field on com_tags edit.

Testing Instructions

see #39441
Ty to add a new tag in the parent selection field.

Actual result BEFORE applying this Pull Request

see #39441

Expected result AFTER applying this Pull Request

The parent tag allows seleting a tag as parent but does not accept the input of a new tag name.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Copy Markdown
Contributor

Not sure this is quite correct.

If you look at the category selector in com_categories and enter a non-existant category as the parent you can not - pressing enter that this point does nothing
image

But even with this pr when you do the same in tags then pressing enter will appear to create the tag except its not saved.
image

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Dec 19, 2022

Agree, The tag field should behave like the categoryedit field. At the moment it os not clear how the categoryedit field should work see #39440.
This is a quick fix to resolve the ugly error message,

I don't mind to close this one and re-open the issue. Unfortunately don't have time for diving deeper into nested set.

@joomdonation
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 922e402

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2023

I have tested this item ✅ successfully on 922e402


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39443.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@fancyFranci fancyFranci merged commit 1a4ca33 into joomla:4.2-dev Jan 10, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.7 milestone Jan 10, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2023
@fancyFranci
Copy link
Copy Markdown
Contributor

Great, thank you!

charvimehradu pushed a commit to charvimehradu/joomla-cms that referenced this pull request Jan 26, 2023
@chmst chmst deleted the tags-disable-parent-on-the-fly branch August 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants