[4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2#39401
Merged
obuisard merged 9 commits intojoomla:4.3-devfrom Dec 17, 2022
Merged
Conversation
This was referenced Dec 13, 2022
Member
Author
|
Due to a discussion in my other PR #39413 I'd like to have a decision if I shall remove the following lines from this PR https://github.com/joomla/joomla-cms/pull/39401/files#diff-db7eb77540ff419bd7e6557d2779f4cf1e31158c20cb4b63dbbe8d6c426385adR6486-R6491 , therefore I set the RLDQ label. |
Member
Author
|
We have discussed in the CMS Maintainers team. I will modify this PR here on Friday because I don't have the time today and tomorrow. As it looks now (still collecting opinions), the JS files will be removed from the list of files to be deleted on update. |
Member
Author
Contributor
Contributor
|
Thank you, Richard @richard67, as always. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Update the section comments for deleted files and folders for 4.3 and to the current 4.3.0-alpha1.
Update deleted files to changes from following PRs:
/plugins/content/emailcloak/emailcloak.php/plugins/content/fields/fields.phpFor the same reason, the deleted js files from PR [4.3] Massmail: Fix validation #39374 are not added to the list with change 2. above.
The broken build will be fixed with another PR, see discussion in my PR's [4.3] Fix broken package build after merge of PR #39374 #39408 and [4.3] Handle missing file in updateAsset method of the versioning js when building packages #39413 .
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.3.0-alpha1 or any older 4.x version to the last 4.3 nightly build to get the actual result, and update a 4.3.0-alpha1 or any older 4.x version to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
Files and folders mentioned at item 2 of the description above are still present after updating from a 4.3.0-alpha1 or any older 4.x version.
Expected result AFTER applying this Pull Request
All files and folders mentioned at item 2 of the description above have been deleted after updating from a 4.3.0-alpha1 or any older 4.x version.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed