[4.3] Massmail: Fix validation by Hackwar · Pull Request #39374 · joomla/joomla-cms

Hackwar · 2022-12-07T13:15:38Z

Pull Request for Issue #33450.

Summary of Changes

Please see the original issue for the problem. Simply said, the mass mail feature has a custom, stupid form validation. This PR uses the default Joomla validation and also the default markup.

Testing Instructions

Go to mass mail in the users menu.
Click on "Send Mail" (without filling out any data)

Actual result BEFORE applying this Pull Request

The form is not send and you get a blue box stating an error. Clicking again will add yet another blue box each time.

Expected result AFTER applying this Pull Request

Sending the form is prevented and all invalid fields are marked red. In addition, there is a message at the top. Clicking again will re-validate and only display one message at the top.

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Deprecate massmail error strings Manual#68

Quy · 2022-12-08T01:43:38Z

Add padding/spacing.

Hackwar · 2022-12-08T09:17:45Z

@Quy done

richard67 · 2022-12-11T15:17:37Z

I have tested this item ✅ successfully on 5e9c489

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.}

richard67 · 2022-12-11T15:18:44Z

The deleted JS file will be added to the list of files to be deleted on update in script.php with another PR. I will care for that.

MacJoom · 2022-12-12T21:12:05Z

I have tested this item ✅ successfully on 5e9c489

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.}

richard67 · 2022-12-12T21:14:25Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39374.}

obuisard · 2022-12-13T11:02:09Z

Thank you Hannes @Hackwar for the PR!

HLeithner · 2022-12-14T13:39:06Z

Documentation PR is wrong because it misses the removed JS file... this PR should have not been merged with a wrong documentation PR, also the documentation PR has to be merged at the same time as the PR it self....

Hackwar · 2022-12-14T13:49:18Z

Are you saying that we can't remove the JS? Or just to extend the documentation PR?

richard67 · 2022-12-14T13:51:53Z

Are you saying that we can't remove the JS? Or just to extend the documentation PR?

@Hackwar That's actually subject of discussion in the maintainers channel on Mattermost and in my PR #39413 and in my previous PR #39408 .

This reverts commit eea6085.

…o be b/c for layout overrides (#39431)

Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.

…#39374 (#40302) * Finally delete deprecated javascript assets Delete the js files and the asset once deleted with PR's #38823 and #39374 and then added back with PR #39431 for b/c reasons. * Add the deleted files to script.php

COM_USERS_MAIL_PLEASE_FILL_IN_THE_FORM_CORRECTLY="Please fill in the form correctly." This string was marked as deprecated in joomla#39374 and removed from 5.0 as a result of the deprecation However this was in error as the string is used https://github.com/joomla/joomla-cms/blob/43a9aab4992d3048e8f2ee5091cd76959fc52acc/administrator/components/com_users/src/Model/MailModel.php#L126 This simple PR restores the string. I have made it against 5.0 as I see this as a bugfix but maintainers may decide its a new string and therefore must be in 5.1

Hackwar added 2 commits December 7, 2022 13:54

Massmail: Fix validation

eb0643c

Deprecating language strings

04708f2

joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Dec 7, 2022

This was referenced Dec 7, 2022

Deprecate massmail error strings joomla/Manual#68

Merged

[4.0] [Mass Mail Users] Infinite repeating error when clicking the Submit button #33450

Closed

[4.0] Large indentation of checkboxes in mass mailing #33434

Closed

Adding spacing between subject and message

77ee15b

Fixing markup

5e9c489

richard67 mentioned this pull request Dec 12, 2022

[4.3] Update deleted files list in script.php for upcoming 4.3.0-alpha2 #39401

Merged

4 tasks

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 12, 2022

Merge branch '4.3-dev' into 4.3-massmail-1

b02165b

obuisard added this to the Joomla! 4.3.0 milestone Dec 13, 2022

obuisard merged commit 9b8e5bc into joomla:4.3-dev Dec 13, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 13, 2022

richard67 mentioned this pull request Dec 13, 2022

[4.3] Fix broken package build after merge of PR #39374 #39408

Closed

4 tasks

richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 13, 2022

Add deleted files from PR joomla#39374

eea6085

richard67 mentioned this pull request Dec 13, 2022

[4.3] Handle missing file in updateAsset method of the versioning js when building packages #39413

Closed

4 tasks

jgerman-bot mentioned this pull request Dec 14, 2022

[4.3] Massmail: Fix validation joomlagerman/joomla#2687

Closed

joomlapl-bot mentioned this pull request Dec 14, 2022

[4.3] Massmail: Fix validation JoomlaPolska/jezyk-J4#287

Closed

richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022

Restore assets deleted with joomla#38823 and joomla#39374

62212d2

richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022

Revert "Add deleted files from PR joomla#39374"

afa4981

This reverts commit eea6085.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 16, 2022

Restore original js from before joomla#38823 and joomla#39374

92226e6

richard67 mentioned this pull request Dec 16, 2022

[4.3] Restore js files deleted with PR's #38823 and #39374 in order to be b/c for layout overrides #39431

Merged

4 tasks

obuisard pushed a commit that referenced this pull request Dec 17, 2022

[4.3] Restore js files deleted with PR's #38823 and #39374 in order t…

5bc91f4

…o be b/c for layout overrides (#39431)

brianteeman mentioned this pull request Apr 2, 2023

[5.0] remove deprecated strings #40296

Closed

4 tasks

richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2023

Finally delete deprecated javascript assets

b35341f

Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2023

Finally delete deprecated javascript assets

11f1f5f

Delete the js files and the asset once deleted with PR's joomla#38823 and joomla#39374 and then added back with PR joomla#39431 for b/c reasons.

richard67 mentioned this pull request Apr 2, 2023

[5.0] Finally delete deprecated javascript assets from PR's #38823 and #39374 #40302

Merged

2 tasks

Hackwar deleted the 4.3-massmail-1 branch April 17, 2023 07:37

This was referenced Jun 27, 2023

[5.0] "node build/build.js --versioning" fails due to missing file "admin-users-mail.min.js" #41066

Closed

[5.0] Remove obsolete assets for com_users.admin-users-mail to fix broken versioning on build #41068

Merged

brianteeman mentioned this pull request Nov 22, 2023

[5.0] revert string removal #42388

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[4.3] Massmail: Fix validation#39374

[4.3] Massmail: Fix validation#39374
obuisard merged 5 commits intojoomla:4.3-devfrom
Hackwar:4.3-massmail-1

Hackwar commented Dec 7, 2022 •

edited

Loading

Uh oh!

Quy commented Dec 8, 2022

Uh oh!

Hackwar commented Dec 8, 2022

Uh oh!

richard67 commented Dec 11, 2022

Uh oh!

richard67 commented Dec 11, 2022

Uh oh!

MacJoom commented Dec 12, 2022

Uh oh!

richard67 commented Dec 12, 2022

Uh oh!

obuisard commented Dec 13, 2022

Uh oh!

HLeithner commented Dec 14, 2022

Uh oh!

Hackwar commented Dec 14, 2022

Uh oh!

richard67 commented Dec 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Hackwar commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

Quy commented Dec 8, 2022

Uh oh!

Hackwar commented Dec 8, 2022

Uh oh!

richard67 commented Dec 11, 2022

Uh oh!

richard67 commented Dec 11, 2022

Uh oh!

MacJoom commented Dec 12, 2022

Uh oh!

richard67 commented Dec 12, 2022

Uh oh!

obuisard commented Dec 13, 2022

Uh oh!

HLeithner commented Dec 14, 2022

Uh oh!

Hackwar commented Dec 14, 2022

Uh oh!

richard67 commented Dec 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Hackwar commented Dec 7, 2022 •

edited

Loading