Skip to content

[4] Template. Allow manifest tag inheritable = 0 or empty#39329

Merged
fancyFranci merged 5 commits intojoomla:4.2-devfrom
ReLater:patch-1
Feb 3, 2023
Merged

[4] Template. Allow manifest tag inheritable = 0 or empty#39329
fancyFranci merged 5 commits intojoomla:4.2-devfrom
ReLater:patch-1

Conversation

@ReLater
Copy link
Copy Markdown
Contributor

@ReLater ReLater commented Nov 29, 2022

Summary of Changes

Allow tag <inheritable>0</inheritable> in templateDetails.xml. Use empty() instead of !isset().

Testing Instructions

<?xml version="1.0" encoding="utf-8"?>
<extension version="4.3" type="template">
	<name>nonamespacedummynoparent</name>
	<creationDate>2022-10-21</creationDate>
	<author>Me</author>
	<authorEmail>joomla@invalid.domain</authorEmail>
	<authorUrl>http://example.com</authorUrl>
	<copyright>Copyright (C) All rights reserved.</copyright>
	<version>1.0</version>
	<description>Test template for namespaces no namespace with no parent</description>
	<inheritable>0</inheritable>
	<files folder="templates/nonamespacedummynoparent">
		<folder>helpers</folder>
		<filename>index.php</filename>
		<filename>templateDetails.xml</filename>
	</files>

	<positions>
		<position>mainmenu</position>
	</positions>
</extension>
  • In backend go to templates (not styles).
  • Click template link "Nonamespacedummynoparent Details and Files"

Actual result BEFORE applying this Pull Request

A error message:

The template folder is not writable. Some features may not work.

grafik

Expected result AFTER applying this Pull Request

No error message

Comment

My build procedure for templates fills tags like inheritable using placeholders like <inheritable>{{inheritable}}</inheritable>. So I think values 0, 1, empty should be accepted without a misleading error message.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ReLater
Copy link
Copy Markdown
Contributor Author

ReLater commented Nov 29, 2022

BTW: The issue came up while testing #39011

@ReLater ReLater mentioned this pull request Nov 29, 2022
4 tasks
GHSVS-de added a commit to GHSVS-de/tpl_herzpraxis_astroid_ghsvs that referenced this pull request Jan 9, 2023
- new placeholder {{inheritable}} because of Joomla bug joomla/joomla-cms#39329
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 24, 2023

I have tested this item ✅ successfully on 9ae0b1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9ae0b1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 25, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 25, 2023
@fancyFranci fancyFranci merged commit e16a837 into joomla:4.2-dev Feb 3, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.8 milestone Feb 3, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 3, 2023
@fancyFranci
Copy link
Copy Markdown
Contributor

One less error message. Thanks!

@ReLater
Copy link
Copy Markdown
Contributor Author

ReLater commented Feb 25, 2023

Please revert this pr. See #39934

@ReLater
Copy link
Copy Markdown
Contributor Author

ReLater commented Feb 25, 2023

See also pr #39943 that reverts this change in J!4.3

@ReLater ReLater mentioned this pull request May 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants