[4] Template. Allow manifest tag inheritable = 0 or empty#39329
Merged
fancyFranci merged 5 commits intojoomla:4.2-devfrom Feb 3, 2023
ReLater:patch-1
Merged
[4] Template. Allow manifest tag inheritable = 0 or empty#39329fancyFranci merged 5 commits intojoomla:4.2-devfrom ReLater:patch-1
fancyFranci merged 5 commits intojoomla:4.2-devfrom
ReLater:patch-1
Conversation
Contributor
Author
|
BTW: The issue came up while testing #39011 |
4 tasks
GHSVS-de
added a commit
to GHSVS-de/tpl_herzpraxis_astroid_ghsvs
that referenced
this pull request
Jan 9, 2023
- new placeholder {{inheritable}} because of Joomla bug joomla/joomla-cms#39329
Contributor
|
I have tested this item ✅ successfully on 9ae0b1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 9ae0b1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39329. |
Contributor
|
One less error message. Thanks! |
Contributor
Author
|
Please revert this pr. See #39934 |
Contributor
Author
|
See also pr #39943 that reverts this change in J!4.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Allow tag
<inheritable>0</inheritable>intemplateDetails.xml. Useempty()instead of!isset().Testing Instructions
templateDetails.xmllooks like this (see<inheritable>0</inheritable>):Actual result BEFORE applying this Pull Request
A error message:
The template folder is not writable. Some features may not work.Expected result AFTER applying this Pull Request
No error message
Comment
My build procedure for templates fills tags like
inheritableusing placeholders like<inheritable>{{inheritable}}</inheritable>. So I think values0,1,emptyshould be accepted without a misleading error message.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed