Skip to content

[4.2] fix shortcut Home Dashboard#38632

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
tecpromotion:fix-shortcut-jhomedashboard
Sep 2, 2022
Merged

[4.2] fix shortcut Home Dashboard#38632
roland-d merged 2 commits intojoomla:4.2-devfrom
tecpromotion:fix-shortcut-jhomedashboard

Conversation

@tecpromotion
Copy link
Copy Markdown
Contributor

Summary of Changes

The string JHOMEDASHBOARD="Home Dashboard" was added and the call in shortcut.php was adjusted.

Testing Instructions

Move to different views in the backend and press the key combination J+X.

Actual result BEFORE applying this Pull Request

J+D is only translated if com_cpanel.ini is also loaded. However, this is not always the case in the backend.

J+X displays the correct value "Home Dashboard" for J+D when calling /administrator/index.php.
For example, when calling /administrator/index.php?option=com_content&view=article, it will not be translated.

Expected result AFTER applying this Pull Request

J+D is always translated.

Documentation Changes Required

.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Aug 29, 2022
@brianteeman
Copy link
Copy Markdown
Contributor

Hard for me to test as I cant replicate the problem but the changes make sense

@tecpromotion
Copy link
Copy Markdown
Contributor Author

Hard for me to test as I cant replicate the problem but the changes make sense

@brianteeman just go to https://yourdomain.tld/administrator/index.php?option=com_content&view=article and press J+X

With Debug Language on:
Bildschirmfoto 2022-08-29 um 16 53 25

@webgras
Copy link
Copy Markdown
Contributor

webgras commented Aug 29, 2022

I have tested this item ✅ successfully on 40a7220

I tested this in J4.2 with php 8.1., language string for shortcut description "J+D" is translated now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38632.

@brianteeman
Copy link
Copy Markdown
Contributor

Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.

image

image

@tecpromotion
Copy link
Copy Markdown
Contributor Author

Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.

In 4.2.1-rc2 ?

@webgras
Copy link
Copy Markdown
Contributor

webgras commented Aug 29, 2022

Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.

it is only broken in the dashboard views, like com_contact Dashboard or com_users Dashboard with J+X
i.E. /administrator/index.php?option=com_users&view=users
~~
sorry, my wrong. For me, it is also broken in the edit views (in 4.2.0)

grafik

@brianteeman
Copy link
Copy Markdown
Contributor

I always test on the absolute latest - so the last commit in my install is #38567
image

And tested with Danish
image

@brianteeman
Copy link
Copy Markdown
Contributor

And german

image

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Aug 29, 2022

Very strange - the string is translated without PR,
online and local.
with and without debug mode
on dashboards, in edit and on list views.
PHP 8.1.6

edit: after upgrade, not fresh installation

@tecpromotion
Copy link
Copy Markdown
Contributor Author

I was able to reproduce it and will validate this tomorrow.

@tecpromotion
Copy link
Copy Markdown
Contributor Author

  1. Install a fresh 4.2.0-rc2 or update from 4.1.5
  2. click J+X on Dashboard or anything else - J+D is always translated
  3. click on "Post Installation Messages" and hide all messages
  4. go to dashboard and click J+X - it's working
  5. click anything else - J+D is not translated
  6. click on "Post Installation Messages" and reset all messages
  7. click J+X on Dashboard or anything else - J+D is always translated again!

small video
https://capture.dropbox.com/embed/h1jAJb6IUUKjOkuX

@brianteeman
Copy link
Copy Markdown
Contributor

Bingo - I can now replicate this with your instructions.

The problem exists on any emptystate page.

I think it would be better to find out why that happens than to change the string. This might end up just being a band aid to a bigger problem

@brianteeman
Copy link
Copy Markdown
Contributor

very weird I now see the problem on every page

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 40a7220


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38632.

@roland-d roland-d merged commit 7f72d6c into joomla:4.2-dev Sep 2, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Sep 2, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.2 milestone Sep 2, 2022
@tecpromotion
Copy link
Copy Markdown
Contributor Author

Thanks @roland-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants