Conversation
|
@Stuartemk could you give this a test please and see if it resolves your issue? |
|
@roland-d I had the same issue and it's solved with this fix. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38490. |
|
I have tested this item ✅ successfully on f1a8fd2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38490. |
|
@alikon How do I get the lifetime to be infinite? |
|
@roland-d check linked PR joomla-cms/libraries/src/Version.php Lines 309 to 310 in 937df36 It will be more safe than hacking every potential issue with Cache drivers. You will update or I do PR? |
|
in redis term if something "never expire" the there is no need to setex() just store it set() |
Yeah, but we also better cover our backs. |
|
@Fedik changed INF to 315576000 |
|
@alikon the RedisStorageCache file should not show a change anymore and it looks like it has a tab/space too many. Could you check please? |
|
I have tested this item ✅ successfully on abadf05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38490. |
|
@RodHub can you please do one more test? Thanks in advance |
|
The code comment before the changed line does not fit any more. Could you please edit it and explain the 10 years in the comment? :) |
The comment is not applicable anymore
|
RTC |
Pull Request for Issue #38473 .
Summary of Changes
deal with INFinite 😄
introduced by #37457
Testing Instructions
use redis Cache Handler
Actual result BEFORE applying this Pull Request
Redis::setex(): Argument #2 ($expire) must be of type int, float given
Expected result AFTER applying this Pull Request
works as before