Skip to content

working link to license#38366

Merged
roland-d merged 3 commits intojoomla:4.2-devfrom
brianteeman:gpl
Aug 3, 2022
Merged

working link to license#38366
roland-d merged 3 commits intojoomla:4.2-devfrom
brianteeman:gpl

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Pull Request for Issue #38326

Summary of Changes

Change the link from gnu.org which now orevents access in an iframe to the help site where @ceford created the correct page

Testing Instructions

Make sure the licence link works

image

@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 1, 2022

I have tested this item 🔴 unsuccessfully on 9f07308

Header is set to X-Frame-Options "SAMEORIGIN" of the Joomla docs help file.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38366.

@brianteeman
Copy link
Copy Markdown
Contributor Author

Sorry - forgot to commit the last change

@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 1, 2022

I have tested this item ✅ successfully on d106e06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38366.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 1, 2022

I have tested this item ✅ successfully on d106e06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38366.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 1, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38366.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 1, 2022
@roland-d roland-d merged commit 7cf5e12 into joomla:4.2-dev Aug 3, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 3, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 3, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.0 milestone Aug 3, 2022
@brianteeman brianteeman deleted the gpl branch August 3, 2022 21:16
rdeutz pushed a commit to joomla-projects/joomla-cms that referenced this pull request Aug 8, 2022
* working link to license

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants