Merged
Conversation
Contributor
|
Works for me This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360. |
Contributor
|
I have tested this item ✅ successfully on c85a03e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360. |
Contributor
|
I have tested this item ✅ successfully on 0f33664 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360. |
Contributor
|
Thank you |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Aug 2, 2022
rdeutz
pushed a commit
to joomla-projects/joomla-cms
that referenced
this pull request
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new feature in 4.2 and the RTL css is wrong - please make this a release blocker @roland-d @richard67
Summary of Changes
For some reason Bootstrap uses text-align: left instead of logical properties for this which completely breaks the layout in RTL so we sadly need to add an rtl override.
Testing Instructions
This is a css change so either
npm run build:cssor install a pre-built packageActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required