Skip to content

Do not show the webauthn form on the registration page#38341

Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom
roland-d:feature/38260-add-missing-string
Jul 31, 2022
Merged

Do not show the webauthn form on the registration page#38341
fancyFranci merged 2 commits intojoomla:4.2-devfrom
roland-d:feature/38260-add-missing-string

Conversation

@roland-d
Copy link
Copy Markdown
Contributor

@roland-d roland-d commented Jul 29, 2022

Pull Request for Issue #38260 .

Summary of Changes

This change adds:

  • the missing language string in case a user account cannot be found
  • does not show the webauthn form on the user registration page
  • Removed an unused use statement

Testing Instructions

See issue #38260 for the excellent test instructions, picture by picture.

  1. Take the steps as outlined in [4.2] webauthn missing string? #38260
  2. Confirm you see the Web Authentication on the registration page and the missing language string
  3. Apply the patch
  4. Refresh the registration page and the Web Authentication should be gone
  5. Login as a user
  6. Go to edit your profile
  7. Verify you see the Web Authentication form

Actual result BEFORE applying this Pull Request

The Web Authentication form is shown on the user registration page

Expected result AFTER applying this Pull Request

The Web Authentication form is not shown on the user registration page

Documentation Changes Required

None

Signed-off-by: Roland Dalmulder <contact@rolandd.com>
@obuisard
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 35cfb41

Works the way it should


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.

@brianteeman
Copy link
Copy Markdown
Contributor

You have a mix of tabs and spaces for the indentations

@nikosdion
Copy link
Copy Markdown
Contributor

@roland-d I am on vacation until the 22nd of August. I won't be able to do a code review in time for the release.

Signed-off-by: Roland Dalmulder <contact@rolandd.com>
@roland-d
Copy link
Copy Markdown
Contributor Author

@brianteeman Thank you, should be fixed.

@nikosdion No problem, thank you for responding. Enjoy the holidays.

@tecpromotion
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on bd6af9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.

@tecpromotion
Copy link
Copy Markdown
Contributor

@roland-d I am on vacation until the 22nd of August. I won't be able to do a code review in time for the release.

enjoy your holidays 🏖️

@tecpromotion
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 35cfb41Works the way it should

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.

@obuisard can you please run a new test. thanks

@richard67
Copy link
Copy Markdown
Member

@tecpromotion No need for @obuisard to test again because the only change after his test was code style only (Just reviews by me). I will restore the test in the issue tracker so it’s properly counted.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.

@tecpromotion
Copy link
Copy Markdown
Contributor

@tecpromotion No need for @obuisard to test again because the only change after his test was code style only (Just reviews by me). I will restore the test in the issue tracker so it’s properly counted.

Thanks @richard67.
Please add label RTC after restore the test.
This PR is still coming in 4.2.0 and the translators can then add the language string asap.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 30, 2022
@richard67
Copy link
Copy Markdown
Member

@tecpromotion No need to remind me to set RTC. I know what to do.

I‘ve set the release blocker label as inherited from the issue.

@fancyFranci fancyFranci merged commit b219703 into joomla:4.2-dev Jul 31, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 31, 2022
@zero-24 zero-24 added this to the Joomla! 4.2.0 milestone Aug 1, 2022
@roland-d roland-d deleted the feature/38260-add-missing-string branch August 1, 2022 06:23
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Aug 2, 2022
* Do not show the webauthn form on the registration page

Signed-off-by: Roland Dalmulder <contact@rolandd.com>

* Changed tabs to spaces

Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Kostelano added a commit to JPathRu/localisation that referenced this pull request Aug 6, 2022
rdeutz pushed a commit to joomla-projects/joomla-cms that referenced this pull request Aug 8, 2022
* Do not show the webauthn form on the registration page

Signed-off-by: Roland Dalmulder <contact@rolandd.com>

* Changed tabs to spaces

Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants