Skip to content

[4.2] Webauth Authenticator Table#38320

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
heelc29:patch-webauth-table
Jul 29, 2022
Merged

[4.2] Webauth Authenticator Table#38320
roland-d merged 2 commits intojoomla:4.2-devfrom
heelc29:patch-webauth-table

Conversation

@heelc29
Copy link
Copy Markdown
Contributor

@heelc29 heelc29 commented Jul 21, 2022

Summary of Changes

Fix colspan if attestation support is enabled

Testing Instructions

  • no webauthn authenticator is registered
  • check table if attestation support is enabled
  • check table if attestation support is not enabled

Actual result BEFORE applying this Pull Request

colspan is wrong (if attestation support is enabled)
image

Expected result AFTER applying this Pull Request

colspan is correct
image

Documentation Changes Required

No

@Kostelano
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 18499b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38320.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 18499b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38320.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38320.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2022
@roland-d roland-d merged commit be0f306 into joomla:4.2-dev Jul 29, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 29, 2022
@roland-d roland-d added this to the Joomla! 4.2.0 milestone Jul 29, 2022
@heelc29 heelc29 deleted the patch-webauth-table branch July 30, 2022 07:56
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Aug 2, 2022
rdeutz pushed a commit to joomla-projects/joomla-cms that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants