Remove filename from mod_quickicon manifest#38309
Merged
roland-d merged 2 commits intojoomla:4.2-devfrom Jul 29, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on fdaa4cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309. |
Contributor
|
I have tested this item ✅ successfully on fdaa4cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309. |
Contributor
|
Thank you. |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Aug 2, 2022
rdeutz
pushed a commit
to joomla-projects/joomla-cms
that referenced
this pull request
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38307 .
Summary of Changes
Removes the obsolete
<filename module="mod_quickicon">mod_quickicon.php</filename>from file "administrator/modules/mod_quickicon/mod_quickicon.xml" and use themoduleattribute on the "services" folder like it is correct here for another module: https://github.com/joomdonation/joomla-cms/blob/4.2-dev/modules/mod_articles_latest/mod_articles_latest.xml#L14I haven't deeply checked if there is already a PR which solves that. On a quick search I haven't found one. If there is one, I will of course close mine in favour of that one.
Testing Instructions
Code review and check that quickicon modules are still working in backend.
Actual result BEFORE applying this Pull Request
Quickicon modules are working but the manifest contains the obsolete
<filename>element for a not existing file.Expected result AFTER applying this Pull Request
Quickicon modules are still working and the manifest XML is correct.
Documentation Changes Required
None.