Skip to content

[4.2] Fix Deprecated warnings on login#38300

Merged
roland-d merged 1 commit intojoomla:4.2-devfrom
joomdonation:fix_depcreated_warnings_com_users
Jul 29, 2022
Merged

[4.2] Fix Deprecated warnings on login#38300
roland-d merged 1 commit intojoomla:4.2-devfrom
joomdonation:fix_depcreated_warnings_com_users

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

Pull Request for Issue #38296.

Summary of Changes

This PR provides default value for $params->get method calls to fixed deprecated warnings as described at #38296

Testing Instructions

  1. Install latest 4.2.0
  2. Confirm the issue as described at [4.2] Deprecated on login #38296
  3. Apply patch, confirm that the issue fixed.

Actual result BEFORE applying this Pull Request

Deprecated warnings on login page on PHP 8.1

Expected result AFTER applying this Pull Request

The deprecated warnings are gone.

Documentation Changes Required

None.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 95da71f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38300.

@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Jul 19, 2022
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jul 19, 2022

I have tested this item ✅ successfully on 95da71f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38300.

@joomla-cms-bot joomla-cms-bot removed the PHP 8.x PHP 8.x deprecated issues label Jul 19, 2022
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jul 19, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38300.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 19, 2022
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Jul 19, 2022
@roland-d roland-d merged commit 956caaf into joomla:4.2-dev Jul 29, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 29, 2022
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@roland-d roland-d added this to the Joomla! 4.2.0 milestone Jul 29, 2022
@joomdonation joomdonation deleted the fix_depcreated_warnings_com_users branch August 1, 2022 08:49
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Aug 2, 2022
rdeutz pushed a commit to joomla-projects/joomla-cms that referenced this pull request Aug 8, 2022
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Dec 7, 2022
Identical PR to # joomla#38300 but for logout instead of login
roland-d pushed a commit that referenced this pull request Dec 17, 2022
Identical PR to # #38300 but for logout instead of login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants