[4.2] com_media (Mediamanager) configuration view. Text fields to textarea.#38281
Merged
roland-d merged 8 commits intojoomla:4.2-devfrom Aug 1, 2022
GHSVS-de:mm-textarea
Merged
[4.2] com_media (Mediamanager) configuration view. Text fields to textarea.#38281roland-d merged 8 commits intojoomla:4.2-devfrom GHSVS-de:mm-textarea
roland-d merged 8 commits intojoomla:4.2-devfrom
GHSVS-de:mm-textarea
Conversation
|
I have tested this item ✅ successfully on 5373646 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281. |
Contributor
|
I have tested this item ✅ successfully on 5d534b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281. |
Contributor
|
Thank you |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Aug 2, 2022
…tarea. (joomla#38281) * restrict_uploads_extensions * image_extensions * audio_extensions * video_extensions and doc_extensions * ignore_extensions * upload_mime
rdeutz
pushed a commit
to joomla-projects/joomla-cms
that referenced
this pull request
Aug 8, 2022
…tarea. (joomla#38281) * restrict_uploads_extensions * image_extensions * audio_extensions * video_extensions and doc_extensions * ignore_extensions * upload_mime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed field types
texttotextarea:upload_mime_illegalChecked that
array_map('trim', explode())is used consistently at all relevant code points and adapted the code if not. To clarify that step: Joomla core usesarray_map('trim', explode())nearly at all code points when reading these parameters. I took it over where not.I haven't included field
upload_mime_illegalbecause I couldn't find any usage in core (#38280).Testing Instructions
BEFORE applying this Pull Request
See that some fields are really hard to configure if you use higher window zoom and/or smaller devices:
Expected result AFTER applying this Pull Request
Nothing changed but the UI view.
array_map('trim', explode())in core now.Change some configuration settings and test if uploads still work like configured even if you add spaces or newlines after commas in textarea. Commas as separators are still mandatory as before!