Fix error (stdClass|array) to string conversion in article version history#38273
Merged
roland-d merged 5 commits intojoomla:4.2-devfrom Jul 29, 2022
templaza:4.2-dev
Merged
Fix error (stdClass|array) to string conversion in article version history#38273roland-d merged 5 commits intojoomla:4.2-devfrom templaza:4.2-dev
roland-d merged 5 commits intojoomla:4.2-devfrom
templaza:4.2-dev
Conversation
…story Display (Array | Object) attribs parameters as String in Article Version History
Member
|
Does this solve issue #38261 ? If so, please mention that in the description of your pull request. |
richard67
reviewed
Jul 14, 2022
administrator/components/com_contenthistory/tmpl/preview/preview.php
Outdated
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on bb4dd6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38273. |
Contributor
|
We have another successful test reported in german Joomla forum but the person doesn't have accounts on GitHub or Joomla issue tracker. Perhaps you will accept that test anyway? |
Member
|
RTC as there were 2 successful tests reported, just one of them not in the issue tracker. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38273. |
|
'We have another successful test reported in german Joomla forum but the person doesn't have accounts on GitHub or Joomla issue tracker.' Now i'm here! :-) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38273. |
Contributor
|
@Elwood-B it is already RTC, no more actions needed for now. |
Contributor
|
Thank you |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Aug 2, 2022
…story (joomla#38273) * Fix error (stdClass|array) to string conversion in article version history Display (Array | Object) attribs parameters as String in Article Version History * Fix the code style error. * Improve the code style. Co-authored-by: Sonny <sonvnn@gmail.com>
rdeutz
pushed a commit
to joomla-projects/joomla-cms
that referenced
this pull request
Aug 8, 2022
…story (joomla#38273) * Fix error (stdClass|array) to string conversion in article version history Display (Array | Object) attribs parameters as String in Article Version History * Fix the code style error. * Improve the code style. Co-authored-by: Sonny <sonvnn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display (Array | Object) attribs parameters as String in Article Version History
Pull Request for Issue #38261 .
Summary of Changes
Article attribs can contain Array or Object properties, they are not properly displayed in backend Article Version History
Testing Instructions
Install Astroid Framework that sets some article attribs parameters as arrays.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
(Array | Object) parameters will display in JSON String format
This pull request will solve issue #38261
Documentation Changes Required
No need