[4.2] Fix missing language strings at installation#38080
Merged
roland-d merged 1 commit intojoomla:4.2-devfrom Jun 17, 2022
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on fc5c8c0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on fc5c8c0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38080. |
Contributor
|
Thank you |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Jun 18, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jul 6, 2022
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38077 .
Summary of Changes
JLIB_INSTALLER_ERROR_DOWNLOAD_SERVER_CONNECTtaken from the "lib_joomla.ini" language file to the installation language file. This is what has been done before with PR [4.1] Missing error strings in installation #37286 for other languages strings from the library which were not translated in the installation.COM_INSTALLER_MSG_INSTALL_INVALID_URLfrom "com_installer.ini". Therefore add a new stingINSTL_ERROR_INVALID_URLto the installation language file and use that string instead of the one from the component in the model.Testing Instructions
It's very likely that you can't reproduce the errors mentioned in the description of issue #38077 to cause the untranslated string being shown, so we might be limited to code review here.
But if you can reproduce it, then please do a real test and report back how you have tested.
Actual result BEFORE applying this Pull Request
Untranslated strings mentioned in the issue are shown in certain case of error.
Expected result AFTER applying this Pull Request
The strings are translated in this particular case of error.
Documentation Changes Required
None.