Skip to content

[4.2] Convert the checkfiles plugin to service provider#38072

Merged
roland-d merged 23 commits intojoomla:4.2-devfrom
Digital-Peak:j4/plugins/checkfiles
Jul 3, 2022
Merged

[4.2] Convert the checkfiles plugin to service provider#38072
roland-d merged 23 commits intojoomla:4.2-devfrom
Digital-Peak:j4/plugins/checkfiles

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Jun 16, 2022

Summary of Changes

Converts the checkfiles plugin to service provider and adds some unit tests. This pr is based on #38060, so please test that one first.

Testing Instructions

  • Create a folder in images with the name test and upload there a big image from unsplash or so which is bigger than 1080 pixels
  • Go to the task scheduler back end list
  • Click on new "Image Size Check"
  • Select the test image in the task parameters
  • Save the task and close the form
  • Run the task by clicking on "Run Test" button

Actual result BEFORE applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

Expected result AFTER applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

@alikon alikon mentioned this pull request Jun 21, 2022
Merged
heelc29
heelc29 suggested changes Jun 21, 2022
View reviewed changes
heelc29
heelc29 reviewed Jun 21, 2022
View reviewed changes
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jun 22, 2022

I have tested this item ✅ successfully on db97381

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38072.

@joomla-bot
Copy link
Copy Markdown
Contributor

joomla-bot commented Jun 27, 2022

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Jun 27, 2022

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

there was a merge error on this pull request please check if worked correctly

@laoneo laoneo closed this Jun 28, 2022
@laoneo laoneo force-pushed the j4/plugins/checkfiles branch from 76900de to 2f45696 Compare June 28, 2022 05:41
@laoneo laoneo reopened this Jun 28, 2022
@laoneo laoneo closed this Jun 28, 2022
@laoneo laoneo force-pushed the j4/plugins/checkfiles branch from 4e1a42e to dd91072 Compare June 28, 2022 05:46
@laoneo laoneo reopened this Jun 28, 2022
@laoneo
Copy link
Copy Markdown
Member Author

laoneo commented Jun 28, 2022

I had to redo this pr, @heelc29 can you have a look again if I missed something. Thanks!

heelc29
heelc29 reviewed Jun 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same changes 😅

@laoneo @heelc29
Update plugins/task/checkfiles/checkfiles.xml
06372ed 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 28, 2022
@richard67
Adapt to changes from PR joomla#38072
209a5e0
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 28, 2022
@richard67
Adapt to changes from PR joomla#38072
471a34c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 29, 2022
@richard67
Adapt to changes from PR joomla#38072
baa95d8
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 29, 2022
@richard67
Adapt to changes from PR joomla#38072
18ed2c5
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 29, 2022
@richard67
Adapt to changes from PR joomla#38072
ef4aac3
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 29, 2022
@richard67
Adapt to changes from PR joomla#38072
8e0b97c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 29, 2022
@richard67
Adapt to changes from PR joomla#38072
a6c107a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 29, 2022
@richard67
Adapt to changes from PR joomla#38072
a69b942
richard67 added a commit to richard67/joomla-cms that referenced this pull request Dec 30, 2022
@richard67
Adapt to changes from PR joomla#38072
8dc2a55
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
@richard67
Adapt to changes from PR joomla#38072
eb73b68
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
@richard67
Adapt to changes from PR joomla#38072
0ffae06
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
@richard67
Adapt to changes from PR joomla#38072
99a7728
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
@richard67
Adapt to changes from PR joomla#38072
1a47452
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 22, 2023
@richard67
Adapt to changes from PR joomla#38072
6100c57
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 22, 2023
@richard67
Adapt to changes from PR joomla#38072
caa9b70
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 22, 2023
@richard67
Adapt to changes from PR joomla#38072
a310327
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 4, 2023
@richard67
Adapt to changes from PR joomla#38072
3875226
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 4, 2023
@richard67
Adapt to changes from PR joomla#38072
9a30e83
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 4, 2023
@richard67
Adapt to changes from PR joomla#38072
0a02f5a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 4, 2023
@richard67
Adapt to changes from PR joomla#38072
1987a5c
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 18, 2023
@richard67
Adapt to changes from PR joomla#38072
6a53b0b
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 18, 2023
@richard67
Adapt to changes from PR joomla#38072
48faba2
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 18, 2023
@richard67
Adapt to changes from PR joomla#38072
45bde18
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 18, 2023
@richard67
Adapt to changes from PR joomla#38072
a0b53d8
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 18, 2023
@richard67
Adapt to changes from PR joomla#38072
b92cae7
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
@richard67
Adapt to changes from PR joomla#38072
fd11b75
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
@richard67
Adapt to changes from PR joomla#38072
208f81d
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
@richard67
Adapt to changes from PR joomla#38072
2e50678
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
@richard67
Adapt to changes from PR joomla#38072
1001ca7
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 5, 2023
@richard67
Adapt to changes from PR joomla#38072
d25bf29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richard67 richard67 richard67 left review comments

@chmst chmst Awaiting requested review from chmst

@bembelimen bembelimen Awaiting requested review from bembelimen

@HLeithner HLeithner Awaiting requested review from HLeithner

@zero-24 zero-24 Awaiting requested review from zero-24

@rdeutz rdeutz Awaiting requested review from rdeutz

@Hackwar Hackwar Awaiting requested review from Hackwar

+2 more reviewers

@heelc29 heelc29 heelc29 requested changes

@roland-d roland-d roland-d approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Unit/System Tests

Projects

None yet

Milestone

Joomla! 4.2.0

Development

Successfully merging this pull request may close these issues.

8 participants

@laoneo @alikon @joomla-bot @HLeithner @roland-d @richard67 @heelc29 @joomla-cms-bot