Skip to content

[4.2] Convert mod_articles_latest to new structure#37947

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
joomdonation:covert_mode_articles_latest
Jun 12, 2022
Merged

[4.2] Convert mod_articles_latest to new structure#37947
roland-d merged 4 commits intojoomla:4.2-devfrom
joomdonation:covert_mode_articles_latest

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

@joomdonation joomdonation commented May 31, 2022

Pull Request for Issue # .

Summary of Changes

This PR converts mod_articles_latest to new structure

Testing Instructions

  1. Use Joomla 4.2
  2. Create an instance of Articles - Latest module. Note how it works.
  3. Apply patch
  4. Delete administrator/cache/autoload_psr4.php
  5. Refresh the page, make sure the module still displays the same as before.

@richard67
Copy link
Copy Markdown
Member

richard67 commented May 31, 2022

@joomdonation Could you fix the PHP CS issue reported by drone?

@toivo
Copy link
Copy Markdown
Contributor

toivo commented Jun 1, 2022

I have tested this item ✅ successfully on 5baff2a

Tested successfully in Joomla 4.2.0-beta1-dev of 1 June.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@pabloarias
Copy link
Copy Markdown

pabloarias commented Jun 10, 2022

I have tested this item ✅ successfully on 5baff2a

Hello:

I used Joomla! version 4.2.0-beta1-dev and PHP 8.1.5.

Installed Blog Sample Data and created module Articles - Latest. It works fine.

If I delete the file before apply the path, it works fine.

After applying the path, it works too.

Thank you and best regards

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Jun 10, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2022
richard67
richard67 reviewed Jun 10, 2022
View reviewed changes
@roland-d roland-d merged commit 42e25d6 into joomla:4.2-dev Jun 12, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jun 12, 2022

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
@joomdonation joomdonation deleted the covert_mode_articles_latest branch June 12, 2022 09:39
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
17e6f58
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b32f536
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
189027b
@richard67 richard67 mentioned this pull request Jun 12, 2022
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
f17f819
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
fc50bf3
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
26eed08
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
0dafaaf
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
c760fe8
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
ba5a951
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
f65138a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
48680bb
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b03b015
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b2c8c96
roland-d pushed a commit that referenced this pull request Jun 20, 2022
@richard67
[4.2] Update deleted files and folders for 4.2.0-beta2 (#38039)
8806607 
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
4b87c7e
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
e32ca4f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
9f9438a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
56312d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richard67 richard67 richard67 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@joomdonation @richard67 @toivo @pabloarias @roland-d @joomla-cms-bot