[4.3] Inject the database into workflow#37628
Merged
obuisard merged 14 commits intojoomla:4.3-devfrom Jan 19, 2023
Merged
Conversation
roland-d
suggested changes
Jun 18, 2022
roland-d
approved these changes
Jun 20, 2022
Contributor
|
A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#26 |
PSR-12 conversion
Member
Author
|
Doc article is here joomla/Manual#79 |
Contributor
|
Thank you Allon @laoneo ! |
HLeithner
pushed a commit
to joomla/Manual
that referenced
this pull request
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Ongoing effort to inject the database into components and get rid of the deprecated Factory::getDbo(); calls. As workflow offers already the possibility to inject the database, this pr changes the usages where a workflow is instantiated to inject the dependencies. Additionally it deprecates the usage of null dependencies and removes some dead code.
Testing Instructions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.