Fix deprecation warning in com_tags#37568
Merged
laoneo merged 4 commits intojoomla:4.1-devfrom Jun 3, 2022
Merged
Conversation
Member
|
@chmst The issue which you have closed for this PR was not an issue but a PR, too. Maybe the issue tracker hasn’t shown that? |
Contributor
Author
|
Not used to github on my IDE ;) |
Contributor
|
If this is a better solution than my PR just close mine, no problem. |
Contributor
Author
|
Sorry ;) By chance I ad exactly the same code open when your PR appeared. I think your solution is better. Both resolve the deprecated warning. |
Member
|
While this here is a correct fix, I'm wondering why it returns here an array with only one element that is again an array of properties. Should it not return just the array with properties? |
Contributor
Author
|
I mentioned already that this method looks strange. A method getItem() should return an Item, not an array and have one integer as argument, not an array. This fix resolves only the php 8.1 warning, |
laoneo
approved these changes
May 19, 2022
Contributor
|
I have tested this item ✅ successfully on a105ac7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on a105ac7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37567 .
Summary of Changes
The method getItem() returns an array but this is initialsed with "false".
Remark: It looks wrong that getItem() returns an array, but this is not in scope of this fix.
Testing Instructions
See #37567
Actual result BEFORE applying this Pull Request
Deprecation warning
Expected result AFTER applying this Pull Request
No deprecation warning
Documentation Changes Required
no