[4.1] PHP 8.1 Deprecation warning TagModel#37567
Closed
frostmakk wants to merge 2 commits intojoomla:4.1-devfrom
Closed
[4.1] PHP 8.1 Deprecation warning TagModel#37567frostmakk wants to merge 2 commits intojoomla:4.1-devfrom
frostmakk wants to merge 2 commits intojoomla:4.1-devfrom
Conversation
Contributor
|
Closing. Please test #37568 |
|
I have tested this item ✅ successfully on 189d60f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567. |
2 similar comments
|
I have tested this item ✅ successfully on 189d60f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567. |
Member
|
I have tested this item ✅ successfully on 189d60f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567. |
|
I have tested this item ✅ successfully on 189d60f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567. |
Member
|
The correct way is the fix from #37568 as the item needs to be an array as you can see here . So the item needs to be initialized as array. and returned as array. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing Instructions
Install 4.1 with sample data.
Run on PHP 8.1 with maximum error reporting.
Go to front end and click on a tag.
Actual result BEFORE applying this Pull Request
PHP Deprecated: Automatic conversion of false to array is deprecated in ..\components\com_tags\src\Model\TagModel.php on line 318
Expected result AFTER applying this Pull Request
No deprecation warning from TagModel
Documentation Changes Required