woohoo!!

Can we use the same technique to do something that @wilsonge and I talked about for the language installation step which is to display the current installation language as the default option

Can we use the same technique to do something that @wilsonge and I talked about for the language installation step which is to display the current installation language as the default option

You mean, when I select de-DE, that this language pack is installed by default (when available) or is on top of the list?

There are good reasons for it not to be installed by default. For example you are installing in german but the site is for a french client.

I just mean that german is either at the top of the list or it stays in the same position but it is preselected as the default in that list.

Hope that makes sense

This method is not needed, to pre-select the installation language, we can just use the value of the dropdown:

$model   = new SetupModel;
$options = $model->getOptions();

print_r($options['language']);

Then we just have to sort it up here based on this value.

To be honest I never really looked to see how to do it. Something I can work on tomorrow

Unrelated to this PR, but I've seen it when testing: Have you noticed that there are 2 entries "English (United Kingdom)" in the language selection? One of them should be "English (New Zealand)", but that's only clear when checking the HTML:

Is this a known issue and already reported somewhere?

I have tested this item ✅ successfully on cd2e2db

Works for me. However I'm not sure yet if the failing drone could be related.

no its a bug. If you look at the xml

no its a bug. If you look at the xml

@brianteeman Do you know if this has to be fixed here in the repo or on Crowdin?

@bembelimen Drone failing again at the API tests at the installation step. Last time it was the system test at the same place, and the time before again the API test. Always at the installation after having selected the language. It seems it is not always failing, but often. Maybe the tests need a little adjustment?

no its a bug. If you look at the xml

@brianteeman Do you know if this has to be fixed here in the repo or on Crowdin?

sorry dont know

no its a bug. If you look at the xml

@brianteeman Do you know if this has to be fixed here in the repo or on Crowdin?

sorry dont know

I've proposed the fix on Crowdin.

This is almost perfect but not quite - the problem is when the browser has both a language option and a language+country variant as for example in german

If you have one of the variants as your default browser language and joomla has that variant then it works perfectly

if you have one of the variants as your default browser language and joomla does not have any variants then it works perfectly

The problem is if you have one of the pure languages which joomla obviously does not have
OR if you have one of the variants and joomla has variants but not that one.

In this case Joomla offers you the last variant in the list

Is this solvable? I suspect its not and I am only reporting this just in case. It is definitely better than it was before this pr

I have tested this item ✅ successfully on cd2e2db

@bembelimen I'd set RTC now as it has 2 tests, but there is still the drone failure of which I'm not sure if it is related.

RTC

@laoneo Hmm, we still have the constantly failing installation in drone, due to which I was told I should not set RTC.

When @roland-d would do an update of the 4.2-dev branch to the current 4.1-dev branch (so-called "upmerge"), we could see if the fix in the installation language file for the duplicate "English (United Kingdom)" will help with the tests so it's clear they do not fail due to this PR (and beside that would help me with rebasing some other PRs from 4.1-dev to 4.2-dev).

Ok, restarted drone and it fails again. So time to remove RTC again.

Back to pending.

@richard67 Upmerge done

@roland-d Thanks. Will update the branch of this PR here now.

RTC but with an unanswered bug ? #37252 (comment)

That bug already exists in 3.x (and should be fixed for sure) but is not related to this PR.
As Joomla! looks only in the first two characters (de-DE => de) or some browser only send the first two characters (de) it takes the first "de" entry from the list. And as de-AT < de-DE it's not the Germany German one which is selected.

That bug already exists in 3.x (and should be fixed for sure) but is not related to this PR

But prior to this PR the language is never preselected.

@bembelimen

As Joomla! looks only in the first two characters (de-DE => de) or some browser only send the first two characters (de) it takes the first "de" entry from the list.

Where is this done?

That bug already exists in 3.x (and should be fixed for sure) but is not related to this PR

But prior to this PR the language is never preselected.

In 3.x it is, it was broken in 4.0 (which is fixed with this PR again) but the old behaviour is not improved.

Ok

@bembelimen

As Joomla! looks only in the first two characters (de-DE => de) or some browser only send the first two characters (de) it takes the first "de" entry from the list.

Where is this done?

Is the change in the composer lock file correct?

Removed RTC as the pull request is still pending.

Yes, the change in composer lock is correct. That pulls the updated Joomla Browser version, which fixes the issue we had with the tests.

Then this needs to be fixed, before it can be merged.

What needs to be fixed?

The conflict

I've solved the conflicting composer.lock file. The version from this PR was the right one because newer than the one from #37565 .

RTC is still ok, it doesn't need new human tests as all changes after these were only for the automated tests (Joomla browser update) and clean branch updates.

Thanks!