Merged
Conversation
Based on feedback and user requests this simple pr adds a hint for the type of class you can add in the image class for the full article image cc @softforge
Contributor
|
Even those that know how to use classes can have a senior moment so such class hints are really helpful. Its a half way hose to the hard coded way we had in J3 that had left and right switch and the universal way to allow any styling to be added |
Contributor
Author
|
please test and report results |
Contributor
|
@brianteeman could you add is also here joomla-cms/build/media_source/system/js/fields/joomla-media-select.w-c.es6.js Lines 408 to 411 in 7978f28 Something like <div class="input-group">
<label class="input-group-text" for="${this.parentId}-classes">${this.classestext}</label>
<input class="form-control" type="text" id="${this.parentId}-classes" data-is="img-classes"/>
<small for="${this.parentId}-classes">${Joomla.Text._('JLIB_FORM_MEDIA_IMAGE_CLASS_DESC')}</small>
</div>and adding the text here likeText::script('JLIB_FORM_MEDIA_IMAGE_CLASS_DESC', true);BTW the text needs to be in the joomla.ini |
Contributor
Author
|
@dgrammatiko I will do that in a separate pr |
|
I have tested this item ✅ successfully on 1b57e8b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 1b57e8b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267. |
Contributor
|
I have tested this item ✅ successfully on 1b57e8b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback and user requests this simple pr adds a hint for the type of class you can add in the image class for the full article image
cc @softforge